Add configurable Db* special-cases for MA0042/MA0045#1136
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 7, 2026
This was referenced May 7, 2026
Merged
Merged
Merged
Merged
This was referenced May 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0042 and MA0045 were still raising await-using diagnostics for common ADO.NET factory-returned types, including the
SqlDataReaderscenario from #1134. In most real providers,DisposeAsyncfalls back to synchronous disposal in base Db* implementations, so these reports were often false positives.Summary
MA0042.enable_db_special_cases(default:true).DoNotUseBlockingCallInAsyncContextAnalyzerawait-using logic to treat Db* compile-time hierarchies as effectively sealed for:DbConnectionDbCommandDbDataReaderDbTransactionDbBatchDisposeAsyncbelow the relevant Db* base type.enable_sqlite_special_casessemantics remain unchanged).DisposeAsyncoverrides,MA0042.enable_db_special_cases = false,Validation
dotnet test tests/Meziantou.Analyzer.Test/Meziantou.Analyzer.Test.csproj --filter "FullyQualifiedName~DoNotUseBlockingCallInAsyncContextAnalyzer_AsyncContextTests|FullyQualifiedName~DoNotUseBlockingCallInAsyncContextAnalyzer_NonAsyncContextTests"dotnet test tests/Meziantou.Analyzer.Test/Meziantou.Analyzer.Test.csproj /p:RoslynVersion=roslyn4.2 --filter "FullyQualifiedName~DoNotUseBlockingCallInAsyncContextAnalyzer_AsyncContextTests|FullyQualifiedName~DoNotUseBlockingCallInAsyncContextAnalyzer_NonAsyncContextTests"dotnet run --project src/DocumentationGeneratordotnet build Meziantou.Analyzer.slnx