Fix MA0042 false positive when non-generic method has a same-named generic overload with awaitable return type

[Copilot]

MA0042 incorrectly reports a diagnostic when a non-generic method (e.g., TUnit's Assert.That(string?)) coexists with a same-named generic overload (e.g., Assert.That<T>(T)) that returns an awaitable type. The suggested fix (await Assert.That(x)) fails to compile because C# overload resolution always prefers non-generic methods — the call still resolves to the non-awaitable non-generic overload.

Changes

• DoNotUseBlockingCallInAsyncContextAnalyzer.cs: In FindPotentialAsyncEquivalent, skip generic candidates when performing a same-name search (methodName == targetMethod.Name) and the original method is non-generic. Since the compiler will always prefer the non-generic overload at the call site, the generic awaitable variant can never actually be selected by applying await.

• DoNotUseBlockingCallInAsyncContextAnalyzer_AsyncContextTests.cs: Regression test covering the pattern below.

static class Assert
{
    public static ValueAssertion  That(string? value) => ...;   // non-awaitable
    public static ValueAssertion<T> That<T>(T value) => ...;    // awaitable
}

// MA0042 was incorrectly flagged here — the fix would still call That(string?), not That<T>
await Assert.That(x).IsEqualTo("Blah");

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• st8vsblobprodcus339.vsblob.vsassets.io
  • Triggering command: /usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/Meziantou.Analyzer.slnx --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)
  • Triggering command: /usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/tests/Meziantou.Analyzer.Test/Meziantou.Analyzer.Test.csproj --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)