Add MA0193 Round mode analyzer and code fixes#1104
Merged
Conversation
Add MA0193 to enforce explicit MidpointRounding for Round overloads across Math, MathF, decimal, IFloatingPoint<TSelf>, and implementations. Enable MA0193 as suggestion by default, add docs, and add analyzer/fixer tests including one code fix action per MidpointRounding member. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
meziantou
commented
Apr 24, 2026
This was referenced Apr 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Roundwithout an explicitMidpointRoundingmode can produce surprising results because it defaults toToEven. This PR adds a dedicated rule so call sites must choose the rounding behavior intentionally.What changed
Roundoverloads that omitMidpointRoundingfor:Math.Round(...)MathF.Round(...)decimal.Round(...)IFloatingPoint<TSelf>.Round(...)and implementationsSystem.MidpointRoundingmember (for exampleToEven,AwayFromZero,ToZero,ToNegativeInfinity,ToPositiveInfinity).Notes for reviewers
OverloadFinder, so it works for both framework methods andIFloatingPoint<TSelf>implementations.MidpointRoundingvalue.