-
Notifications
You must be signed in to change notification settings - Fork 100
Recursive filter mask zeros modifications #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ify the order of the zeroing application in the plugin such that the variable_mask option still has some meaning in the context of zeroing data.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2199 +/- ##
==========================================
- Coverage 98.39% 95.68% -2.72%
==========================================
Files 124 146 +22
Lines 12212 14519 +2307
==========================================
+ Hits 12016 13892 +1876
- Misses 196 627 +431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brhooper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bayliffe, this change looks sensible to me.
gavinevans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bayliffe 👍
I've suggested fixing one typo.
Co-authored-by: gavinevans <[email protected]>
…tering * upstream/master: Minor correction to write the output file from the test_gam_at_sites acceptance test to a temporary location, as usual. (metoppv#2204) Adds option for a landmask ancillary to be passed into the CLI (metoppv#2202) Mobt775 Add SAMOS apply plugins and all CLIs (metoppv#2153) Recursive filter mask zeros modifications (metoppv#2199) Correct passing through of variables for QRF application (metoppv#2196)
This PR:
New acceptance test data: metoppv/improver_test_data#109
Testing: