Skip to content

Conversation

@bayliffe
Copy link
Contributor

@bayliffe bayliffe commented Oct 3, 2025

This PR:

  • Adds mask_zeros option for recursive filter to the associated CLI
  • Modifies the order of the zeroing application in the plugin such that the variable_mask option still has some meaning in the context of zeroing data. Without this change variable_mask will always have to be set when using mask_zeroing as zero values in the data may appear in different locations in different slices.
  • Adds an acceptance test for the mask_zeroing.

New acceptance test data: metoppv/improver_test_data#109

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

…ify the order of the zeroing application in the plugin such that the variable_mask option still has some meaning in the context of zeroing data.
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.68%. Comparing base (84a8944) to head (63be5d7).
⚠️ Report is 116 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
- Coverage   98.39%   95.68%   -2.72%     
==========================================
  Files         124      146      +22     
  Lines       12212    14519    +2307     
==========================================
+ Hits        12016    13892    +1876     
- Misses        196      627     +431     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

brhooper
brhooper previously approved these changes Oct 3, 2025
Copy link
Contributor

@brhooper brhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bayliffe, this change looks sensible to me.

@gavinevans gavinevans self-assigned this Oct 7, 2025
Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bayliffe 👍

I've suggested fixing one typo.

@bayliffe bayliffe assigned gavinevans and unassigned bayliffe Oct 7, 2025
@gavinevans gavinevans merged commit 1f0eff5 into metoppv:master Oct 7, 2025
7 checks passed
@gavinevans gavinevans assigned bayliffe and unassigned gavinevans Oct 7, 2025
gavinevans added a commit to gavinevans/improver that referenced this pull request Oct 10, 2025
…tering

* upstream/master:
  Minor correction to write the output file from the test_gam_at_sites acceptance test to a temporary location, as usual. (metoppv#2204)
  Adds option for a landmask ancillary to be passed into the CLI (metoppv#2202)
  Mobt775 Add SAMOS apply plugins and all CLIs (metoppv#2153)
  Recursive filter mask zeros modifications (metoppv#2199)
  Correct passing through of variables for QRF application (metoppv#2196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants