Mobt775 Add SAMOS apply plugins and all CLIs #2153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type-hinting for both classes. Add unit tests for both classes.
…in and add calculate_cube_statistics method.
…lculation over time coordinate. Add tests for this method.
…tions for SAMOS. Move generic helper functions for SAMOS unit tests into their own file. Create TrainEMOSForSAMOS class. Create additional unit tests for TrainGAMsForSAMOS. Add scipy monkey patch to pygam imports to work around a known bug.
…orSAMOS to use 2 methods which include all functionality. Add unit tests for TrainEMOSForSAMOS. Minor update to CalculateClimateAnomalies.
…ference_epoch coordinate bounds when the inputs have multiple time points.
…erstand. Improve test of TrainGAMsForSAMOS by predicting from the fitted GAM and comparing the predictions to expected output.
…evant file where there are only used in one file. Improve argument names for some test helper functions. Run pre-commit to fix formatting errors.
…7 production environment, as described in metoppv#2124.
… its own function. Move unit tests accordingly. Respecify expected results of unit tests which use this function, as the random number generation has changed. Create ApplySAMOS class. Formatting changes.
…CLIs for 3 SAMOS classes and add helper function for splitting input cubes to these CLIs. Modify apply EMOS so that it can return location and scale parameters. Move functionality for converting location and scale parameters to forecast values out of apply EMOS plugin. Various small fixes.
…s. Modify calculation of means and standard deviations of cubes in GAMs to collapse over time coordinates.
brhooper
changed the title
gavinevans
requested changes
Sep 30, 2025
Contributor
gavinevans
left a comment
gavinevans
left a comment
There was a problem hiding this comment.
Thanks @brhooper 👍
I've added a few more comments.
improver_tests/acceptance/test_estimate_samos_gams_from_table.py
Outdated
Show resolved
Hide resolved
gavinevans
previously approved these changes
Oct 2, 2025
Contributor
gavinevans
left a comment
gavinevans
left a comment
There was a problem hiding this comment.
Thanks @brhooper 👍
This looks fine to me.
2 tasks
maxwhitemet
requested changes
Oct 7, 2025
improver/utilities/cli_utilities.py
Outdated
Comment on lines
41
to
43
| A list of contained pickled objects. | ||
| or | ||
| None |
Contributor
There was a problem hiding this comment.
Could these lines be rewritten in both functions as 'A list of contained pickle objects, or None.'?
improver_tests/acceptance/test_estimate_samos_gams_from_table.py
Outdated
Show resolved
Hide resolved
maxwhitemet
approved these changes
Oct 8, 2025
Contributor
maxwhitemet
left a comment
maxwhitemet
left a comment
There was a problem hiding this comment.
Happy with the changes made. Approved 👍
2 tasks
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Oct 10, 2025
…tering * upstream/master: Minor correction to write the output file from the test_gam_at_sites acceptance test to a temporary location, as usual. (metoppv#2204) Adds option for a landmask ancillary to be passed into the CLI (metoppv#2202) Mobt775 Add SAMOS apply plugins and all CLIs (metoppv#2153) Recursive filter mask zeros modifications (metoppv#2199) Correct passing through of variables for QRF application (metoppv#2196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/775
Acceptance test data: metoppv/improver_test_data#108
Add plugins for applying a pre-trained SAMOS model to a new forecast. This PR follows on from #2126. I've rebased this branch on master now that the initial training plugin PR has been merged.
This PR now contains an amalgamation of various branches created to add plugins required to apply SAMOS calibration as well as all CLIs for SAMOS calibration.
Testing: