Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maps not being created in CAMS2_83 #1381

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix maps not being created in CAMS2_83 #1381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e95763a
a fix to test wtih charlie
lewisblake Oct 18, 2024
67be8ec
safter version until model_kwargs fixed in pydantic model_entry
lewisblake Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyaerocom/aeroval/modelmaps_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def _run_model(self, model_name: str, var_list):
make_overlay = OVERLAY in self.cfg.modelmaps_opts.plot_types.get(
model_name, False
)

if self.cfg.modelmaps_opts.plot_types == {CONTOUR} or make_contour:
_files = self._process_contour_map_var(
model_name, var, self.reanalyse_existing
Expand Down Expand Up @@ -401,6 +400,7 @@ def _read_model_data(self, model_name: str, var: str) -> GriddedData:
kwargs.update(**self.cfg.colocation_opts.model_kwargs)
if var in self.cfg.colocation_opts.model_read_opts:
kwargs.update(self.cfg.colocation_opts.model_read_opts[var])
kwargs.update(self.cfg.get_model_entry(model_name).get("model_kwargs", {}))

if model_reader is not None and model_reader in MODELREADERS_USE_MAP_FREQ:
ts_types = reader.ts_types
Expand Down