Fix maps not being created in CAMS2_83 #1381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The cams2_83 reader required a
daterange
argument, which was not being picked up in kwargs, partially due to do work that Daniel and I did to move the model_kwargs argument closer to the model entry instance. i.e., not in thecolocation_opts
. This was meant to minimize confusion and simplify things but it was not being picked up in theModelMapsEngine
(which occurs prior to the regular collocations) and hence crashing. In the regular collocation, keys which are in specific model_entry instances are copied over to thecolocation_opts
and the kwargs for the model reader are picked up from there. Hence, why this did not crash the regular collocation code, and only appears in the CAMS2_83, where this specificdaterange
argument is required byreader.read_var()
Related issue number
close #1380
please test @charlienegri
Checklist