Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maps not being created in CAMS2_83 #1381

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Oct 18, 2024

Change Summary

The cams2_83 reader required a daterange argument, which was not being picked up in kwargs, partially due to do work that Daniel and I did to move the model_kwargs argument closer to the model entry instance. i.e., not in the colocation_opts. This was meant to minimize confusion and simplify things but it was not being picked up in the ModelMapsEngine (which occurs prior to the regular collocations) and hence crashing. In the regular collocation, keys which are in specific model_entry instances are copied over to the colocation_opts and the kwargs for the model reader are picked up from there. Hence, why this did not crash the regular collocation code, and only appears in the CAMS2_83, where this specific daterange argument is required by reader.read_var()

Related issue number

close #1380

please test @charlienegri

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake changed the title Fix maps not beign created in CAMS2_83 Fix maps not being created in CAMS2_83 Oct 18, 2024
@lewisblake lewisblake added this to the m2024-11 milestone Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.54%. Comparing base (9300b96) to head (67be8ec).
Report is 18 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1381      +/-   ##
============================================
+ Coverage     78.50%   78.54%   +0.03%     
============================================
  Files           136      137       +1     
  Lines         20860    20900      +40     
============================================
+ Hits          16377    16415      +38     
- Misses         4483     4485       +2     
Flag Coverage Δ
unittests 78.54% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charlienegri
Copy link
Collaborator

charlienegri commented Oct 18, 2024

output is being produced 👍 , I think this is ready to be merged

@lewisblake lewisblake marked this pull request as ready for review October 18, 2024 13:39
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@thorbjoernl thorbjoernl merged commit 41b6db7 into main-dev Oct 18, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the cams283_maps_1380 branch October 18, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maps calculations for cams2_83 fail
3 participants