Skip to content

Revert "Revert Bump sushy-tools and allow to ignore boot device#619

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
hardys:revert_revert_sushy
Mar 29, 2021
Merged

Revert "Revert Bump sushy-tools and allow to ignore boot device#619
metal3-io-bot merged 1 commit intometal3-io:masterfrom
hardys:revert_revert_sushy

Conversation

@hardys
Copy link
Copy Markdown
Member

@hardys hardys commented Mar 29, 2021

This reverts #609 and restores #606

FIXME - testing CI with the original broken version, then the issue
identified will be fixed before merging:
#606 (comment)

This reverts commit 505dcf0.

@metal3-io-bot
Copy link
Copy Markdown
Collaborator

metal3-io-bot commented Mar 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2021
@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2021
@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

This still has the issue mentioned in https://github.com/metal3-io/metal3-dev-env/pull/606/files#r595873052 which led to the revert

Since metal3-io/project-infra#175 landed we should see the integration tests fail this time, when that's confirmed I'll fix the issue and re-run the CI

@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

/test-integration

@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

Ok we see that CI is working - it is failing to deprovision as was reported via #609

TASK [v1aX_integration_test : Wait until "2" bmhs become ready again.] *********
�[1;30mtask path: /home/****/tested_repo/vm-setup/roles/v1aX_integration_test/tasks/cleanup.yml:34�[0m
�[0;31mfatal: [localhost]: FAILED! => {�[0m

I'll now fix the problem and we'll hopefully see this pass

@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

/test-integration

@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

/test-centos-integration

@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

/retitle Revert "Revert Bump sushy-tools and allow to ignore boot device

@metal3-io-bot metal3-io-bot changed the title WIP: Revert "Revert Bump sushy-tools and allow to ignore boot device Revert "Revert Bump sushy-tools and allow to ignore boot device Mar 29, 2021
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2021
@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2021
@hardys hardys force-pushed the revert_revert_sushy branch from 0dc1d56 to 5bc7e51 Compare March 29, 2021 12:52
@hardys hardys force-pushed the revert_revert_sushy branch from 5bc7e51 to 1e575b4 Compare March 29, 2021 12:53
@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

/test-integration

@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

/test-centos-integration

@hardys
Copy link
Copy Markdown
Member Author

hardys commented Mar 29, 2021

Ok this passed CI with the fix applied, so I squashed the fix into the revert commit - this should be good to merge when the integration tests pass I think.

@furkatgofurov7
Copy link
Copy Markdown
Member

furkatgofurov7 commented Mar 29, 2021

Hi, @hardys thanks for working on the fix for this! This LGTM.

@fmuyassarov
Copy link
Copy Markdown
Member

fmuyassarov commented Mar 29, 2021 •
edited
Loading

Since the issue was caught in v1alpha4 job too, I don't think there is a need to trigger v1a3 too.
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2021
@metal3-io-bot metal3-io-bot merged commit df37af2 into metal3-io:master Mar 29, 2021
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 13, 2021
Bump metal3-dev-env version
cb15bfb 
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
@hardys hardys mentioned this pull request Apr 13, 2021
Merged
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 13, 2021
Bump metal3-dev-env version
247ab5f 
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 14, 2021
Bump metal3-dev-env version
699b040 
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
@fmuyassarov fmuyassarov mentioned this pull request Apr 17, 2021
Closed
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 20, 2021
Bump metal3-dev-env version
3afc02d 
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 20, 2021
Bump metal3-dev-env version
ad975c4 
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
openshift-merge-robot pushed a commit to openshift-metal3/dev-scripts that referenced this pull request Apr 20, 2021
Bump metal3-dev-env version (#1221)
7fa7e1a 
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref #1193 since that needs
the sushy_ignore_boot_device option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

@maelk maelk Awaiting requested review from maelk

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hardys @metal3-io-bot @furkatgofurov7 @fmuyassarov