Bump sushy-tools and allow to ignore boot device#606
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom Mar 15, 2021
Merged
Bump sushy-tools and allow to ignore boot device#606metal3-io-bot merged 1 commit intometal3-io:masterfrom
metal3-io-bot merged 1 commit intometal3-io:masterfrom
Conversation
metal3-io-bot
added
approved
metal3-io-bot
added
size/XS
Member
Author
|
/cc @derekhiggins |
The latest release adds a variable that allows us to test setting the boot device via efibootmgr, when combined with the live-iso disk format this can be used to install e.g using the Fedora CoreOS iso.
Member
|
/lgtm |
Collaborator
|
@derekhiggins: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
/test-integration |
iurygregory
approved these changes
Mar 3, 2021
iurygregory
approved these changes
Mar 4, 2021
elfosardo
approved these changes
Mar 8, 2021
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, hardys, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/test-centos-integration |
Member
|
/lgtm |
dtantsur
reviewed
Mar 17, 2021
| dest: "{{ working_dir }}/virtualbmc/sushy-tools/conf.py" | ||
| content: | | ||
| SUSHY_EMULATOR_LIBVIRT_URI = "{{ vbmc_libvirt_uri }}" | ||
| SUSHY_EMULATOR_IGNORE_BOOT_DEVICE = "{{ sushy_ignore_boot_device }}" |
Member
There was a problem hiding this comment.
This is a string that always evaluates to True in Python. You need to remove the quotes.
hardys
pushed a commit
to hardys/metal3-dev-env
that referenced
this pull request
Mar 29, 2021
…to fix CI" This reverts metal3-io#609 and restores metal3-io#606 FIXME - testing CI with the original broken version, then the issue identified will be fixed before merging: metal3-io#606 (comment) This reverts commit 505dcf0.
hardys
pushed a commit
to hardys/metal3-dev-env
that referenced
this pull request
Mar 29, 2021
…x CI" This reverts metal3-io#609 and restores metal3-io#606 Fix added for issue mentioned in: https://github.com/metal3-io/metal3-dev-env/pull/606/files#r595873052 This will also be tested by CI since: metal3-io/project-infra#175 This reverts commit 505dcf0.
hardys
pushed a commit
to hardys/metal3-dev-env
that referenced
this pull request
Mar 29, 2021
This reverts metal3-io#609 and restores metal3-io#606 Fix added for issue mentioned in: https://github.com/metal3-io/metal3-dev-env/pull/606/files#r595873052 This will also be tested by CI since: metal3-io/project-infra#175 This reverts commit 505dcf0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest release adds a variable that allows us to test setting
the boot device via efibootmgr, when combined with the live-iso
disk format this can be used to install e.g using the Fedora
CoreOS iso.
https://review.opendev.org/c/openstack/releases/+/778023
https://review.opendev.org/c/openstack/sushy-tools/+/776660