Support for local image building#104
Conversation
|
/test-integration |
|
/test-centos-integration |
stbenjam
force-pushed
the
local-images
branch
from
30bc959 to
d119a01
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
|
/test-integration |
|
/test-centos-integration |
|
This looks good to me, we've found these interfaces to be very convenient for local image testing in dev-scripts so it will be good to add them here, I guess it may simplify CI testing as well when we have cross-repo dependencies in future. Other than needing the BMO PR to land first this lgtm, added @maelk for review too |
stbenjam
force-pushed
the
local-images
branch
2 times, most recently
from
43f1189 to
7d083bc
Compare
|
/test-centos-integration |
|
/test-integration |
maelk
left a comment
maelk
left a comment
There was a problem hiding this comment.
aside of the podman reference, this looks good to me
This ports the local image building code form OpenShift dev-scripts to metal3-dev-env. It starts a local registry, and if a user has specified _LOCAL_IMAGE variables, will build and push those images to the registry. `kustomize` is used to override the images in baremetal-operator. Example: ``` export IRONIC_LOCAL_IMAGE=file:///home/notstack/ironic-image make ```
|
/test-integration |
|
/test-centos-integration |
|
/lgtm |
4 participants
This ports the local image building code form OpenShift dev-scripts to
metal3-dev-env. It starts a local registry, and if a user has specified
_LOCAL_IMAGE variables, will build and push those images to the
registry.
kustomizeis used to override the images in baremetal-operator.Example: