Skip to content

Use kustomize for deploying baremetal-operator#324

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
stbenjam:config-map
Oct 23, 2019
Merged

Use kustomize for deploying baremetal-operator#324
metal3-io-bot merged 1 commit intometal3-io:masterfrom
stbenjam:config-map

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Oct 17, 2019 •
edited
Loading

This changes make deploy to use kustomize to deploy the BMO. For the IPv6 work, it makes it very easy to override certain fields in the config map, or image names.

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2019
@hardys hardys mentioned this pull request Oct 17, 2019
Merged
9 tasks
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2019
@stbenjam stbenjam mentioned this pull request Oct 18, 2019
Merged
hardys
hardys reviewed Oct 21, 2019
View reviewed changes
Comment thread deploy/ironic_bmo_configmap.yaml Outdated
@stbenjam stbenjam changed the title [WIP] Allow overriding BMO config map Use kustomize for deplyoment BMO Oct 22, 2019
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2019
@stbenjam stbenjam mentioned this pull request Oct 22, 2019
Closed
@stbenjam
Use kustomize for deploying baremetal-operator
d6c4d0f 
This changes `make deploy` to use kustomize to deploy the BMO. For the
IPv6 work, it makes it very easy to override certain fields in the
config map or image names.

To override certain values, it's possible to create an "overlay" that's
based on the primary kustomization.yaml.
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Oct 22, 2019 •
edited
Loading

This should be ready for a review, the approach has changed somewhat and now uses kustomize. A PR to run CI showing this works is metal3-io/metal3-dev-env#103. It should not affect OpenShift dev-scripts.

/cc @sadasu
/cc @dhellmann
/cc @hardys

@stbenjam stbenjam mentioned this pull request Oct 22, 2019
Merged
@stbenjam stbenjam changed the title Use kustomize for deplyoment BMO Use kustomize for deploying baremetal-operator Oct 23, 2019
dhellmann
dhellmann approved these changes Oct 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. There were 2 other reviewers so I'll leave it open for a bit in case they want a chance to look things over.

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@sadasu
Copy link
Copy Markdown
Member

sadasu commented Oct 23, 2019

Minor comment : It would be good to name the configmap "metal3-config" making it consistent with what it is being called in the MAO and installer. (Renaming deploy/ironic_bmo_configmap.env to metal3-config.env is probably the 1st step.)
I'll leave it up to you to decide if you want to rename and if that will happen in this patch or a later one.

@sadasu
Copy link
Copy Markdown
Member

sadasu commented Oct 23, 2019

/approve

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Oct 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, sadasu, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Oct 23, 2019

@sadasu Thanks, I think that's a better name. I'd prefer to do it in a follow-up.

Would you mind giving this a /lgtm too?

Thanks!!

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Oct 23, 2019

@sadasu: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sadasu
Copy link
Copy Markdown
Member

sadasu commented Oct 23, 2019

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@metal3-io-bot metal3-io-bot merged commit e14b956 into metal3-io:master Oct 23, 2019
@stbenjam stbenjam deleted the config-map branch October 23, 2019 19:59
jgato pushed a commit to jgato/baremetal-operator that referenced this pull request Apr 26, 2024
@openshift-merge-bot
Merge pull request metal3-io#324 from zaneb/openshift-4.14/logging-st…
94e9d34 
…ructured-timestamp-again

[release-4.14] OCPBUGS-24409: Don't munge timestamp in structured logs, again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann dhellmann approved these changes

@hardys hardys Awaiting requested review from hardys

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@sadasu sadasu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stbenjam @sadasu @metal3-io-bot @dhellmann @hardys