Skip to content

✨ Uplift controller runtime, controller-tools and cluster-api#56

Merged
metal3-io-bot merged 3 commits intometal3-io:masterfrom
Nordix:uplift/controller-runtime
Sep 28, 2021
Merged

✨ Uplift controller runtime, controller-tools and cluster-api#56
metal3-io-bot merged 3 commits intometal3-io:masterfrom
Nordix:uplift/controller-runtime

Conversation

@kashifest
Copy link
Copy Markdown
Member

@kashifest kashifest commented Sep 27, 2021

In this PR we,

  • uplift controller-runtime to v0.10.1
  • uplift controller-tools to v0.7.0
  • uplift CAPI to v0.4.3

The changes are influenced by: kubernetes-sigs/cluster-api#5249

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 27, 2021
@kashifest
Copy link
Copy Markdown
Member Author

kashifest commented Sep 27, 2021

/test-integration

@kashifest
Copy link
Copy Markdown
Member Author

kashifest commented Sep 27, 2021

/assign @fmuyassarov
/cc @jan-est

namnx228
namnx228 approved these changes Sep 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@namnx228 namnx228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov
Copy link
Copy Markdown
Member

fmuyassarov commented Sep 27, 2021

/test-centos-integration
/test-v1a4-integration
/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2021
@fmuyassarov
Copy link
Copy Markdown
Member

fmuyassarov commented Sep 27, 2021

/test-centos-integration

@fmuyassarov
Copy link
Copy Markdown
Member

fmuyassarov commented Sep 27, 2021

/test-v1a4-integration

@kashifest
Copy link
Copy Markdown
Member Author

kashifest commented Sep 27, 2021 •
edited
Loading

v1a4 would fail on this @fmuyassarov

@fmuyassarov
Copy link
Copy Markdown
Member

fmuyassarov commented Sep 27, 2021

v1a4 would fail on this @fmuyassarov

Ops, sorry Kashif. I completely forgot about the API type here.

@kashifest kashifest force-pushed the uplift/controller-runtime branch from eda4fe0 to e6c6cf9 Compare September 27, 2021 12:20
@kashifest
Copy link
Copy Markdown
Member Author

kashifest commented Sep 27, 2021

/test-centos-integration
/test-integration

@kashifest
Copy link
Copy Markdown
Member Author

kashifest commented Sep 27, 2021

Ops, sorry Kashif. I completely forgot about the API type here.

No worries. Re-ran v1a5 tests again. Lets see.

@jan-est
Copy link
Copy Markdown

jan-est commented Sep 27, 2021 •
edited
Loading

LGTM lets wait for the tests to pass

@kashifest kashifest force-pushed the uplift/controller-runtime branch from e6c6cf9 to 01ab1e1 Compare September 28, 2021 06:32
@kashifest
Copy link
Copy Markdown
Member Author

kashifest commented Sep 28, 2021

/test-centos-integration
/test-integration

@kashifest
Copy link
Copy Markdown
Member Author

kashifest commented Sep 28, 2021

/test-integration

@jan-est
Copy link
Copy Markdown

jan-est commented Sep 28, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
smoshiur1237
smoshiur1237 approved these changes Sep 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Sep 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, namnx228, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 6359b31 into metal3-io:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

@jan-est jan-est Awaiting requested review from jan-est

+1 more reviewer

@namnx228 namnx228 namnx228 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fmuyassarov fmuyassarov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kashifest @fmuyassarov @jan-est @metal3-io-bot @namnx228 @smoshiur1237