⚠️ Upgrade to controller-runtime v0.10, controller-tools v0.7 and Kubernetes v1.22#5249
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Sep 21, 2021
Conversation
k8s-ci-robot
added
cncf-cla: yes
sbueringer
changed the title
sbueringer
force-pushed
the
pr-upgrade-controller-runtime
branch
from
23f009f to
1695468
Compare
sbueringer
commented
Sep 16, 2021
sbueringer
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-upgrade-controller-runtime
branch
from
1695468 to
902eee9
Compare
sbueringer
commented
Sep 16, 2021
| g.Expect(env.Create(ctx, machine)).To(Succeed()) | ||
| // Note: We have to DeepCopy the machine, because the Create call clears the status and | ||
| // reconcileInterruptibleNodeLabel requires .status.nodeRef to be set. | ||
| g.Expect(env.Create(ctx, machine.DeepCopy())).To(Succeed()) |
Member
Author
There was a problem hiding this comment.
Note: this was an intended change in controller-runtime: kubernetes-sigs/controller-runtime#1640
sbueringer
commented
Sep 16, 2021
| Name: "test-cluster", | ||
| }, | ||
| } | ||
| g.Expect(k8sClient.Create(ctx, clusterA)).To(Succeed()) |
Member
Author
There was a problem hiding this comment.
The Create call updates the empty map to nil.
I assume also a consequence of this change kubernetes-sigs/controller-runtime#1640
sbueringer
commented
Sep 16, 2021
| mutatingWebhooks := []client.Object{} | ||
| validatingWebhooks := []admissionv1.ValidatingWebhookConfiguration{} | ||
| mutatingWebhooks := []admissionv1.MutatingWebhookConfiguration{} | ||
|
|
Member
Author
There was a problem hiding this comment.
This was necessary because WebhookInstallOptions now expects the correct types and not just client.Object
Member
Author
|
To fix the remaining test failures we need: kubernetes-sigs/controller-runtime#1666 With that fix, I had successful tests locally (via I don't see a good workaround/alternative. |
Member
|
lgtm pending 1666 |
sbueringer
force-pushed
the
pr-upgrade-controller-runtime
branch
from
902eee9 to
507af19
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
I'm now using the latest commit of the CR main branch with my merged PRs, should all work now. |
Contributor
|
is this on hold until the code freeze starts? given that it's breaking |
sbueringer
force-pushed
the
pr-upgrade-controller-runtime
branch
from
d5260f2 to
3bf236d
Compare
k8s-ci-robot
added
size/XL
sbueringer
force-pushed
the
pr-upgrade-controller-runtime
branch
from
3bf236d to
662bbc8
Compare
sbueringer
changed the title
k8s-ci-robot
added
lgtm
sbueringer
force-pushed
the
pr-upgrade-controller-runtime
branch
from
662bbc8 to
8975b65
Compare
k8s-ci-robot
added
size/L
Member
Author
|
flake + GitHub download error |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…kup-fix 🐛 Release Tooling: Version calculation script should only use annotated tags
sbueringer
force-pushed
the
pr-upgrade-controller-runtime
branch
from
8975b65 to
81c140d
Compare
k8s-ci-robot
removed
the
lgtm
Member
Author
|
This PR now uses the latest CR v0.10.1 release. I updated the PR description to also close #5277 |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5245
Now also fixes #5277
WIP => debugging tests