🌱 Uplift golangc-lint in hack/tools/go.mod#206
Merged
Merged
Conversation
metal3-io-bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
kashifest
force-pushed
the
uplift/golangc-lint
branch
from
578fa98 to
8c25e7b
Compare
metal3-io-bot
added
size/XXL
kashifest
force-pushed
the
uplift/golangc-lint
branch
2 times, most recently
from
b2de077 to
0afc32e
Compare
kashifest
force-pushed
the
uplift/golangc-lint
branch
from
0afc32e to
32550c6
Compare
kashifest
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/test-integration |
Member
Author
| .PHONY: lint | ||
| lint: $(GOLANGCI_LINT) ## Lint codebase | ||
| $(GOLANGCI_LINT) run -v | ||
| $(GOLANGCI_LINT) run -v --timeout=10m |
Member
There was a problem hiding this comment.
How come we have not tried this :)
Member
|
/test-integration |
Member
|
@fmuyassarov test had been already triggered:grinning: |
Member
Author
|
/test-centos-integration |
honza
pushed a commit
to honza/cluster-api-provider-metal3
that referenced
this pull request
Jan 27, 2025
…penshift-4.16-baremetal-machine-controller OCPBUGS-24919: Updating baremetal-machine-controller-container image to be consistent with ART
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #