🌱 Update golangci-lint to latest

[furkatgofurov7]

What this PR does / why we need it:
Golangci-lint is failing intermittently in a few PRs':

• https://prow.apps.ci.metal3.io/view/gcs/metal3-prow-artifacts/pr-logs/pull/metal3-io_cluster-api-provider-metal3/175/golint/1366761909239418884
• https://prow.apps.ci.metal3.io/view/gcs/metal3-prow-artifacts/pr-logs/pull/metal3-io_cluster-api-provider-metal3/175/golint/1366761909247807489
• https://prow.apps.ci.metal3.io/view/gcs/metal3-prow-artifacts/pr-logs/pull/metal3-io_cluster-api-provider-metal3/157/golint/1366744921666490372
• https://prow.apps.ci.metal3.io/view/gcs/metal3-prow-artifacts/pr-logs/pull/metal3-io_cluster-api-provider-metal3/171/golint/1366751339048079365

This patch updates it to the latest as the speed of the latest version seems to be increased a lot per
golangci/golangci-lint#685 (comment).

Since we moved to go1.16 in #161 we were hitting a go bug (see golint prow job output below, when a workaround is not applied ) for how go build works with modules - golang/go#44129

` + make lint
cd hack/tools; go build -tags=tools -o bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
go: github.com/golangci/golangci-lint@v1.37.1: missing go.sum entry; to add it:
	go mod download github.com/golangci/golangci-lint
make: *** [Makefile:124: hack/tools/bin/golangci-lint] Error 1 `

This commit adds the -mod=mod flag for go build command in the Makefile (workaround mentioned in the issue).

[fmuyassarov]

I think you need to run go mod tidy after updating go.mod.

[furkatgofurov7]

/retest

[fmuyassarov]

/test golint

[fmuyassarov]

/test unit

[fmuyassarov]

/test-integration

[furkatgofurov7]

/test-centos-integration

[fmuyassarov]

@kashifest @furkatgofurov7
I'm not sure how we ended up using gofmt instead of golint. But using golint image from quay instead of golang and replacing hack/gofmt with hack/golint.sh seems to fix the issue.

Quay is building the golint image from https://github.com/metal3-io/baremetal-operator/blob/e74c3d8461e2e5f55d3b0839988d04c254490c1e/hack/Dockerfile.golint

[furkatgofurov7]

/test-centos-integration

@kashifest @furkatgofurov7
I'm not sure how we ended up using gofmt instead of golint. But using golint image from quay instead of golang and replacing hack/gofmt with hack/golint.sh seems to fix the issue.

True, I have not noticed it before, and this should be a bug, IMO? But if just changing to correct image helps, we do not need to bump golangci-lint version at all :/

[fmuyassarov]

/test-integration

[maelk]

/test-integration

[maelk]

/test-integration

[maelk]

/test-centos-integration

[maelk]

/test-centos-integration

[maelk]

/test-centos-integration

[maelk]

/test-centos-integration

[maelk]

/test-integration

[maelk]

/test-integration

[maelk]

/test-integration

[metal3-io-bot]

@furkatgofurov7: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
golint	576bdb0	link	/test golint
generate	576bdb0	link	/test generate

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[furkatgofurov7]

Tackled in #206

/close

[metal3-io-bot]

@furkatgofurov7: Closed this PR.

Details

In response to this:

Tackled in #206

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[metal3-io-bot]

@furkatgofurov7: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.