Skip to content

🏃 Update Baremetal Operator for the new unmanaged state#108

Merged
metal3-io-bot merged 1 commit into
metal3-io:masterfrom
Nordix:v1a4-mael
Jul 9, 2020
Merged

🏃 Update Baremetal Operator for the new unmanaged state#108
metal3-io-bot merged 1 commit into
metal3-io:masterfrom
Nordix:v1a4-mael

Conversation

@maelk
Copy link
Copy Markdown
Member

@maelk maelk commented Jul 7, 2020

What this PR does / why we need it:
This adds support for a new state defined in BMO : metal3-io/baremetal-operator#571

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@maelk
Copy link
Copy Markdown
Member Author

maelk commented Jul 7, 2020

/test-v1a4-integration

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2020
@maelk
Copy link
Copy Markdown
Member Author

maelk commented Jul 7, 2020

/cc @dhellmann

@metal3-io-bot metal3-io-bot requested a review from dhellmann July 7, 2020 05:35
@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Jul 7, 2020

This isn't sufficient by itself. We can't deprovision the host without credentials, so if we have an unmanaged host linked to a machine then we won't be able to delete the machine. To fix that, we also need to update https://github.com/metal3-io/cluster-api-provider-metal3/blob/master/baremetal/metal3machine_manager.go#L568 to include the new state as one for which we no longer need to wait before deleting the machine.

This was referenced Jul 7, 2020
Merged
Merged
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2020
@maelk
Copy link
Copy Markdown
Member Author

maelk commented Jul 9, 2020

/test-v1a4-integration

@maelk
Copy link
Copy Markdown
Member Author

maelk commented Jul 9, 2020

/test generate

dhellmann
dhellmann approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Jul 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 71fa20c into metal3-io:master Jul 9, 2020
honza pushed a commit to honza/cluster-api-provider-metal3 that referenced this pull request Jan 27, 2025
@openshift-merge-robot
Merge pull request metal3-io#108 from dhellmann/unit-test-hack-script
7fa0dc5 
Bug 1874618: add hack scripts to install dependencies for unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhellmann dhellmann dhellmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maelk @dhellmann @metal3-io-bot