define the Unmanaged state#571
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom Jul 7, 2020
Merged
Conversation
Define a new state for newly-created Hosts with no BMC details. We need the state definition so we can add it to CAPM3 so that does not break when metal3-io#569 merges. See metal3-io/metal3-docs#120 for more details.
metal3-io-bot
added
approved
Member
Author
|
/test-integration |
Contributor
|
Looks good to me. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, kirankt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Member
|
@dhellmann Can you please review the two PRs ? Then it should be ready on CAPM3 side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a new state for newly-created Hosts with no BMC details.
We need the state definition so we can add it to CAPM3 so that does
not break when #569 merges.
See metal3-io/metal3-docs#120 for more
details.