Get rid of extra resource write during delete#514
Merged
dhellmann merged 1 commit intometal3-io:masterfrom May 18, 2020
Merged
Conversation
Now that 'deleting' is treated as its own provisioning status, returning actionContinue is sufficient to ensure that the state gets written at the conclusion of reconciliation. Doing an early write will cause an error to be logged when we go to do the final write, since the object generation will no longer match.
metal3-io-bot
added
approved
This was referenced May 12, 2020
Member
|
/test-integration |
1 similar comment
Member
|
/test-integration |
Member
|
/lgtm |
Member
|
It looks like tide got stuck? /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
All of the tests passed, so I'll merge this by hand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that 'deleting' is treated as its own provisioning status, returning
actionContinue is sufficient to ensure that the state gets written at
the conclusion of reconciliation. Doing an early write will cause an
error to be logged when we go to do the final write, since the object
generation will no longer match.