Attempt to power off BareMetalHost before delete by sadasu · Pull Request #412 · metal3-io/baremetal-operator

sadasu · 2020-02-03T20:32:55Z

When a BareMetalHost is deleted, power it off before performing
the delete operation.
Fixes #410

zaneb

Actually, reading through the provisioner code just now, it looks like PowerOff never returns an ErrorMessage. Ideally we would check for one, and if it is present just log it and increment a prometheus metric, then carry on as we're doing here. But given that it can't happen right now, I'm not too worried about it.

sadasu · 2020-04-15T13:46:36Z

/test-integration

zaneb · 2020-05-12T17:25:08Z

I opened a separate PR (#514) to clean up the existing problem with saveStatus, because it turns out it might be related to a bug so that's probably a good reason to keep it separate.

dhellmann · 2020-05-22T18:52:58Z

@sadasu are you still working on this PR?

sadasu · 2020-05-22T20:28:59Z

@sadasu are you still working on this PR?

Yes, trying to understand PR (#514) and modify implementation here.

dhellmann · 2020-05-22T21:08:22Z

@sadasu are you still working on this PR?

Yes, trying to understand PR (#514) and modify implementation here.

Sounds good. There's no particular rush, I was looking at some PRs that I might be able to help with rebasing or something to move forward. Little stuff for a Friday afternoon. :-)

zaneb · 2020-05-22T21:48:34Z

/lgtm

sadasu · 2020-05-26T16:15:07Z

/test-integration

sadasu · 2020-05-26T20:26:11Z

@dhellmann could you please take a look? I need an approve label.

zaneb · 2020-05-27T19:21:18Z

On closer inspection, it looks like the provisioner code doesn't actually check for a failed attempt to power off (it doesn't look at any error messages from Ironic), so I suspect we will just end up retrying forever if the credentials don't work.
In addition, if we can find the host in Ironic (possibly due to a previous call to actionDelete() removing it) then there'll be an error that sends us into an infinite retry loop.
There's no current way to distinguish this error from other errors (other than looking at the text), and in any event it might be wise to just (log +) ignore all errors from this call anyway.

/lgtm cancel

metal3-io-bot · 2020-06-02T20:24:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadasu
To complete the pull request process, please assign zaneb
You can assign the PR to them by writing /assign @zaneb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sadasu · 2020-08-13T15:28:20Z

/test-integration

sadasu · 2020-11-12T16:44:27Z

/test-integration

metal3-io-bot · 2021-02-10T16:51:53Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

s3rj1k · 2021-02-10T18:12:39Z

/remove-lifecycle stale

s3rj1k · 2021-02-10T18:13:46Z

Any updates on this?

sadasu · 2021-03-01T22:06:45Z

/test-integration

sadasu · 2021-03-02T16:17:35Z

/test-integration

sadasu · 2021-03-04T19:10:28Z

/test-integration

sadasu · 2021-03-05T15:34:15Z

/test-integration

sadasu · 2021-03-05T17:19:09Z

/test-integration

sadasu · 2021-03-16T21:55:20Z

Implementation has moved to #816.

metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2020

zaneb reviewed Feb 3, 2020

View reviewed changes

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

zaneb reviewed Feb 10, 2020

View reviewed changes

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

sadasu changed the title ~~WIP: Attempt to power off BareMetalHost before delete~~ Attempt to power off BareMetalHost before delete Feb 26, 2020

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2020

zaneb reviewed May 12, 2020

View reviewed changes

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

metal3-io-bot assigned zaneb May 22, 2020

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2020

dhellmann reviewed May 26, 2020

View reviewed changes

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2020

metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2020

sadasu changed the title ~~Attempt to power off BareMetalHost before delete~~ WIP: Attempt to power off BareMetalHost before delete Jun 2, 2020

metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2020

zaneb reviewed Jun 2, 2020

View reviewed changes

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

Comment thread pkg/controller/baremetalhost/baremetalhost_controller.go Outdated

metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2020

sadasu changed the title ~~WIP: Attempt to power off BareMetalHost before delete~~ Attempt to power off BareMetalHost before delete Aug 13, 2020

sadasu changed the title ~~Attempt to power off BareMetalHost before delete~~ WIP: Attempt to power off BareMetalHost before delete Nov 10, 2020

metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2020

sadasu changed the title ~~WIP: Attempt to power off BareMetalHost before delete~~ Attempt to power off BareMetalHost before delete Nov 12, 2020

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2020

dhellmann reviewed Nov 12, 2020

View reviewed changes

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2021

metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2021

sadasu commented Feb 25, 2021

View reviewed changes

Comment thread pkg/provisioner/provisioner.go Outdated

andfasano reviewed Mar 2, 2021

View reviewed changes

Comment thread pkg/provisioner/ironic/ironic.go

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

andfasano reviewed Mar 3, 2021

View reviewed changes

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

andfasano reviewed Mar 5, 2021

View reviewed changes

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Comment thread pkg/provisioner/ironic/ironic.go Outdated

Attempt to hard power off node before it is deleted

17b0630

andfasano reviewed Mar 8, 2021

View reviewed changes

Comment thread pkg/provisioner/ironic/delete_test.go

sadasu closed this Mar 16, 2021

Conversation

sadasu commented Feb 3, 2020

Uh oh!

Uh oh!

Uh oh!

zaneb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sadasu commented Apr 15, 2020

Uh oh!

Uh oh!

Uh oh!

zaneb commented May 12, 2020

Uh oh!

dhellmann commented May 22, 2020

Uh oh!

sadasu commented May 22, 2020

Uh oh!

dhellmann commented May 22, 2020

Uh oh!

zaneb commented May 22, 2020

Uh oh!

sadasu commented May 26, 2020

Uh oh!

sadasu commented May 26, 2020

Uh oh!

Uh oh!

zaneb commented May 27, 2020

Uh oh!

metal3-io-bot commented Jun 2, 2020

Uh oh!

Uh oh!

Uh oh!

sadasu commented Aug 13, 2020

Uh oh!

sadasu commented Nov 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metal3-io-bot commented Feb 10, 2021

Uh oh!

s3rj1k commented Feb 10, 2021

Uh oh!

s3rj1k commented Feb 10, 2021

Uh oh!

Uh oh!

sadasu commented Mar 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sadasu commented Mar 2, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sadasu commented Mar 4, 2021

Uh oh!

Uh oh!

Uh oh!

sadasu commented Mar 5, 2021

Uh oh!

sadasu commented Mar 5, 2021

Uh oh!

Uh oh!

sadasu commented Mar 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!