Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for parent element to be used in server side environments if document is defined as it is when using JSDom #298

Merged
merged 4 commits into from
Nov 15, 2017

Conversation

robframpton
Copy link

No description provided.

@robframpton
Copy link
Author

Hey @eduardolundgren

This should address the issues your team has run into regarding isomorphic rendering.

Copy link
Contributor

@pragmaticivan pragmaticivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with the build of the 2 libs on our console and that is working again.

@jbalsas jbalsas changed the base branch from develop to master November 15, 2017 08:26
@jbalsas jbalsas merged commit c93201c into metal:master Nov 15, 2017
@jbalsas
Copy link
Contributor

jbalsas commented Nov 15, 2017

Hey @Robert-Frampton, @pragmaticivan, I've released this as 2.14.1 and merged it back into develop. Next time, please make sure you create issues for this. Otherwise, the changelog for the version is a bit funky :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants