-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds lint-staged configuration #293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalsas
force-pushed
the
feature/updated_guidelines
branch
from
November 10, 2017 22:58
911f159
to
2a84dc2
Compare
jbalsas
force-pushed
the
feature/updated_guidelines
branch
from
November 10, 2017 23:28
2a84dc2
to
61d0f4f
Compare
robframpton
approved these changes
Nov 14, 2017
Hey @Robert-Frampton! We should be able to merge to Just to validate, I'm going to merge this in, and then proceed to cut a release from #298... YOLO! |
diegonvs
added a commit
to diegonvs/metal.js
that referenced
this pull request
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Robert-Frampton, please, take this PR with care 😂
This applies the hopefully-final guidelines. I've separated the linting bits in packages for an easier digestion. Things to have in mind:
opt_
prefix). I've left this for the future as well since it requires quite some time to go through it.