Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to create element in Node.js environment #266

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Don't attempt to create element in Node.js environment #266

merged 2 commits into from
Oct 11, 2017

Conversation

robframpton
Copy link

@robframpton robframpton commented Oct 2, 2017 •
edited
Loading

See #264

@robframpton robframpton mentioned this pull request Oct 2, 2017
Closed
@eduardolundgren
Copy link
Contributor

eduardolundgren commented Oct 3, 2017 •
edited
Loading

Can be used isServerSide instead?

metal.js/packages/metal/src/coreNamed.js

Line 292 in 1517926

export function isServerSide() {

@robframpton
Copy link
Author

Hey @eduardolundgren, you're right, didn't see we had that helper util. I'll update this branch.

@robframpton
Copy link
Author

@eduardolundgren, I made the change to both this pull and #264.

@robframpton robframpton mentioned this pull request Oct 3, 2017
Merged
@jbalsas
Copy link
Contributor

jbalsas commented Oct 10, 2017

This LGTM, just waiting to clarify our new branching strategy a little bit before merging!

@robframpton robframpton changed the base branch from master to develop October 10, 2017 16:24
@jbalsas jbalsas merged commit 7d08bc2 into metal:develop Oct 11, 2017
@jbalsas jbalsas added this to the 2.14.0 milestone Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@robframpton @eduardolundgren @jbalsas