importing metal-dom shouldn't immediately throw errors when running in Node.js environment #264
Conversation
| @@ -32,6 +32,9 @@ class features { | |||
| const prefixes = ['Webkit', 'MS', 'O', '']; | |||
| const typeTitleCase = string.replaceInterval(type, 0, 1, type.substring(0, 1).toUpperCase()); | |||
| const suffixes = [`${typeTitleCase}End`, `${typeTitleCase}End`, `${typeTitleCase}End`, `${type}end`]; | |||
| if (!features.animationElement_) { | |||
| features.animationElement_ = document.createElement('div'); | |||
There was a problem hiding this comment.
Hey @Robert-Frampton, won't this still throw on usage on the server?
There was a problem hiding this comment.
Only if checkAnimationEventName_ actually get's invoked, but it should never get invoked on the server. That's why the custom events are only being registered if it's not server side.
There was a problem hiding this comment.
Yeah, I was thinking about other usages not protected here, like https://github.com/metal/metal-anim/blob/master/src/Anim.js#L60
There was a problem hiding this comment.
I think we might just need to state that some packages are not supported in server side rendering. All of the methods in metal-anim require DOM elements, so you really shouldn't be invoking on the server anyways.
There was a problem hiding this comment.
Also, even if a component implemented metal-anim in some way, it probably isn't going to be invoked by renderToString.
Hey @jbalsas
This is just a step towards out of the box isomorphic rendering. With these changes you'll be able to have an import to
metal-domin a Node.js environment without it immediately throwing an error.