Sets its name inside the listener function. Fixes #222 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robframpton
reviewed
Mar 31, 2017
| component = new TestComponent(); | ||
|
|
||
| let config = { | ||
| 'data-on-click': 'handleClick' |
There was a problem hiding this comment.
I know it won't really affect the test, but wouldn't this usually be data-onclick?
There was a problem hiding this comment.
Yeah, @Robert-Frampton, you are right. It will not affect the test but I'm going to change it.
fernandosouza
force-pushed
the
listener-name-fix
branch
from
5cbb433 to
62f8d28
Compare
jbalsas
reviewed
Mar 31, 2017
| @@ -451,6 +451,22 @@ describe('IncrementalDomRenderer', function() { | |||
| }); | |||
|
|
|||
| describe('Inline Listeners', function() { | |||
| it('should shows the listener name in the dom element', function() { | |||
There was a problem hiding this comment.
small typo: shows ==> show
fernandosouza
force-pushed
the
listener-name-fix
branch
from
62f8d28 to
f9fa01e
Compare
|
Branch updated, guys. Thx for reviewing. |
fernandosouza
force-pushed
the
listener-name-fix
branch
from
04ae9e6 to
d7bac21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.