We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, incremental-dom renderer is outputing something like:
<div class="alert alert-dismissible alert-success fade" role="alert"> body <button type="button" class="close" aria-label="Close" data-onclick="data-onclick"> <span aria-hidden="true">×</span> </button> </div>
where it should be rendering
<div class="alert alert-dismissible alert-success fade" role="alert"> body <button type="button" class="close" aria-label="Close" data-onclick="onClickHandler_"> <span aria-hidden="true">×</span> </button> </div>
This is likely caused by https://github.com/metal/metal.js/blob/master/packages/metal-incremental-dom/src/render/attributes.js#L98 where we should do instead fn.givenAsName_ = value;
fn.givenAsName_ = value;
The text was updated successfully, but these errors were encountered:
Hey @fernandosouza, in case you aren't already... could you take a look at this and try to come up with a test and a proper fix?
Thanks!
Sorry, something went wrong.
Sure, @jbalsas.
Sets its name inside the listener function. Fixes metal#222
5cbb433
62f8d28
f9fa01e
Merge pull request #223 from fernandosouza/listener-name-fix
497d8cd
Sets its name inside the listener function. Fixes #222
fernandosouza
No branches or pull requests
Currently, incremental-dom renderer is outputing something like:
where it should be rendering
This is likely caused by https://github.com/metal/metal.js/blob/master/packages/metal-incremental-dom/src/render/attributes.js#L98 where we should do instead
fn.givenAsName_ = value;
The text was updated successfully, but these errors were encountered: