LB-1681: Fix 500 error on artist page #3042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the discussion https://github.com/metabrainz/listenbrainz-server/pull/3029/files#r1842882407, we only support a few formats for the date, but the current way of saving the dates can lead to -MM-DD, -DD, -MM or YYYY-DD format too.
|
Hello @anshg1214! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes LB-1681.
The sorting function for release groups anticipated a complete date as input. However, after the partial date issue was resolved in the PR #3029, the sorting function malfunctioned.
Also, there’s a minor issue when we save the partial dates in our cache. As discussed in the pull request https://github.com/metabrainz/listenbrainz-server/pull/3029/files#r1842882407, we only support a limited set of date formats, but the current method of saving the dates can also result in -MM-DD, -DD, -MM, or YYYY-DD formats.
This PR has been deployed on test.listenbrainz.org.
For reference, here are the links: