Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-1419: Fix broken partial dates #3029

Merged
merged 1 commit into from
Nov 18, 2024
Merged

LB-1419: Fix broken partial dates #3029

merged 1 commit into from
Nov 18, 2024

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Nov 11, 2024

The MB data cashes have invalid partial dates for release_group data. The problem is that when any part of a || concat expression in PG is NULL, the entire result is NULL. The solution is to move the partial data logic into python code.

@pep8speaks
Copy link

Hello @mayhem! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 83:131: E501 line too long (190 > 130 characters)

Line 137:9: E303 too many blank lines (2)

@mayhem
Copy link
Member Author

mayhem commented Nov 14, 2024

This PR is also temporarily deployed, anticipating the monthly rebuild of all of the data.

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we are relying on the date to be parsable anywhere but in case something breaks we should keep this change in mind. Also, you could use COALESCE in postgres to generate the partial dates but python is fine too.

@mayhem mayhem merged commit ea3d16a into master Nov 18, 2024
2 checks passed
@mayhem mayhem deleted the LB-1419 branch November 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants