Return error values rather than throwing #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @crisptrutski and the rest of your teammates on |
crisptrutski
force-pushed
the
consistent-shape
branch
from
2da4018
to
f7f8c1c
Compare
crisptrutski
changed the base branch from
compound-queries
to
graphite-base/108
crisptrutski
force-pushed
the
graphite-base/108
branch
from
fcb9111
to
791ab33
Compare
crisptrutski
force-pushed
the
consistent-shape
branch
from
f7f8c1c
to
8d9896e
Compare
crisptrutski
force-pushed
the
consistent-shape
branch
from
8d9896e
to
4ba3652
Compare
crisptrutski
force-pushed
the
consistent-shape
branch
from
4ba3652
to
a0be40e
Compare
piranha
approved these changes
Oct 25, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93
In Metabase we decided to clean up error handling based on values, as opposed to a mix semantically meaningful
nil, magic keywords, and thrown exceptions.With this change we turn (expected) exceptions into error maps. We also wrap the
tablesin a map, to avoid an awkward untagged union with the error maps.Metabase has been made agnostic to these API changes, so upgrading will be easy.