More advanced table extractor to handle compound queries #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
commented
Oct 24, 2024
crisptrutski
commented
Oct 24, 2024
crisptrutski
changed the title
piranha
reviewed
Oct 24, 2024
| private static void accTables(Select select, Set<Table> tables, Stack<Set<String>> cteAliasScopes) { | ||
| if (select instanceof PlainSelect) { | ||
| accTables(select.getPlainSelect(), tables, cteAliasScopes); | ||
| } else if (select instanceof ParenthesedSelect) { |
There was a problem hiding this comment.
is this ParenthesedSelect a nested select or what?
There was a problem hiding this comment.
Sorry the context has left my brain a bit now 😄
I think you're right, and from a practical point of view its a SELECT which gets bound to an alias.
I can't recall if this is both column and table bindings, or just one of those.
crisptrutski
force-pushed
the
compound-queries
branch
from
d7d114f
to
ffaf13a
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @crisptrutski and the rest of your teammates on |
piranha
approved these changes
Oct 25, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes things much more useful.
Wasn't as bad as I expected!