Consolidate drawGps related code

[Xaositek]

• Consolidate drawGps related code
• Remove redundant drawSatelliteIcon
• Move gps_mode logic within drawGps

Regression tested on Meshnology W12 (Two Color), RAK4631, Cardputer

Summary by CodeRabbit

• Bug Fixes
  • Improved GPS status display across device and position screens.
  • Added distinct messaging for disabled, unavailable, disconnected, unlocked, locked, and fixed-position states.
  • Updated position details to show information based on the active GPS mode or fixed-position settings.

[github-actions]

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7eda1309-fd18-4fc3-ad76-ff116209780a

📥 Commits

Reviewing files that changed from the base of the PR and between 453f885 and 3b72627.

📒 Files selected for processing (1)

• src/graphics/draw/UIRenderer.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• src/graphics/draw/UIRenderer.cpp

---

📝 Walkthrough

Walkthrough

Changes

GPS rendering

Layer / File(s)	Summary
Explicit GPS state rendering src/graphics/draw/UIRenderer.cpp	drawGps now renders distinct status text for fixed, absent, disabled, disconnected, unlocked, and locked GPS states.
Shared GPS rendering integration src/graphics/draw/UIRenderer.cpp	Device-focused and compass/location screens use drawGps. GPS detail rows now depend on GPS configuration state instead of displayed text.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• meshtastic/firmware#11103: Both changes update GPS rendering in UIRenderer.cpp.

Suggested reviewers: thebentern, harukitoreda

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the primary change: consolidating GPS drawing code.
Description check	✅ Passed	The description summarizes the GPS changes and lists regression testing on three supported devices.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch baseui_drawGps_consolidation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/graphics/draw/UIRenderer.cpp`:
- Around line 521-528: Update the GPS status logic in UIRenderer so
config.position.fixed_position is checked before branching on gps_mode, ensuring
fixed-position mode always displays “Fixed GPS,” including when GPS mode is
ENABLED. Preserve the existing GPS-disabled and satellite-status handling for
non-fixed positions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f65ce501-1a4c-4da5-b1fc-988ee33d8d49

📥 Commits

Reviewing files that changed from the base of the PR and between e2460b5 and 453f885.

📒 Files selected for processing (1)

• src/graphics/draw/UIRenderer.cpp