Skip to content

Improve user experience with a new GPS icon for Home and Position frames - #11103

Merged
Xaositek merged 1 commit into
developfrom
baseui_gpsiconupdate
Jul 21, 2026
Merged

Improve user experience with a new GPS icon for Home and Position frames#11103
Xaositek merged 1 commit into
developfrom
baseui_gpsiconupdate

Conversation

@Xaositek

@Xaositek Xaositek commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Improve user experience with a new GPS icon for Home and Position frames
IMG_4419
IMG_4420

Summary by CodeRabbit

  • Bug Fixes
    • Updated the position and GPS status displays to show a dedicated GPS icon instead of the satellite icon.
    • Ensured the correct GPS icon appears across both high-resolution and monochrome display modes.

@Xaositek Xaositek self-assigned this Jul 20, 2026
@Xaositek Xaositek added enhancement New feature or request baseui Issues directly related to BaseUI labels Jul 20, 2026
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c57b7e18-ed28-432b-b713-59c1f734df1f

📥 Commits

Reviewing files that changed from the base of the PR and between 0199a1f and 93a9176.

📒 Files selected for processing (2)
  • src/graphics/draw/UIRenderer.cpp
  • src/graphics/images.h

📝 Walkthrough

Walkthrough

Adds an 8x8 GPS bitmap and replaces satellite bitmap usage with the GPS bitmap in the home/position icon helper and dedicated GPS drawing path across high-resolution and monochrome rendering branches.

Changes

GPS icon rendering

Layer / File(s) Summary
GPS bitmap asset
src/graphics/images.h
Adds the 8x8 imgGPS bitmap and stores its data in program memory.
GPS rendering integration
src/graphics/draw/UIRenderer.cpp
Uses imgGPS instead of imgSatellite in both rendering branches of drawSatelliteIcon and drawGps.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: harukitoreda, caveman99, jp-bennett

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only states the change and includes images, but omits the required attestation/test checklist and testing details. Add the required attestation checklist, note what you tested, mention any device/regression coverage, and include fixes #... if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a new GPS icon for the Home and Position frames.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch baseui_gpsiconupdate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Xaositek
Xaositek requested a review from HarukiToreda July 20, 2026 15:21
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Flash this PR in the Web Flasher

firmware commit boards expires

Warning

This is an automated, unreviewed CI test build. Back up your device configuration
before flashing, and only flash devices you are able to recover.

Supported boards built by this PR (30)
Device Board Platform
Crowpanel Adv 3.5 TFT elecrow-adv-35-tft esp32-s3
Heltec HT62 heltec-ht62-esp32c3-sx1262 esp32-c3
Heltec Mesh Node 096 heltec-mesh-node-t096 nrf52840
Heltec Mesh Node T1 heltec-mesh-node-t1 nrf52840
Heltec Mesh Node T114 heltec-mesh-node-t114 nrf52840
Heltec V3 heltec-v3 esp32-s3
Heltec V4 heltec-v4 esp32-s3
Meshnology W10 meshnology_w10 esp32-s3
Raspberry Pi Pico pico rp2040
Raspberry Pi Pico W picow rp2040
RAK WisMesh Pocket V3 rak_wismesh_pocket nrf52840
RAK WisMesh Pod rak_wismesh_pod nrf52840
RAK WisMesh Repeater Mini V2 rak_wismesh_repeater_mini nrf52840
RAK WisMesh Tag rak_wismeshtag nrf52840
RAK WisBlock 11200 rak11200 esp32
RAK WisBlock 11310 rak11310 rp2040
RAK3312 rak3312 esp32-s3
RAK WisBlock 4631 rak4631 nrf52840
Seeed SenseCAP Mesh-Tracker-X1 seeed_mesh_tracker_X1 nrf52840
Seeed Wio Tracker L1 seeed_wio_tracker_L1 nrf52840
Seeed Xiao NRF52840 Kit seeed_xiao_nrf52840_kit nrf52840
Seeed Xiao ESP32-S3 seeed-xiao-s3 esp32-s3
Station G2 station-g2 esp32-s3
Station G3 station-g3 esp32-s3
LILYGO T-Deck t-deck-tft esp32-s3
LILYGO T-Echo t-echo nrf52840
LILYGO T-Echo Plus t-echo-plus nrf52840
LILYGO T-Impulse Plus t-impulse-plus nrf52840
LilyGo T3-C6 tlora-c6 esp32-c6
Seeed SenseCAP T1000-E tracker-t1000-e nrf52840

Build artifacts expire on 2026-08-19. Updated for 93a9176.

@Xaositek
Xaositek merged commit 65abfaa into develop Jul 21, 2026
108 checks passed
@Xaositek
Xaositek deleted the baseui_gpsiconupdate branch July 21, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

baseui Issues directly related to BaseUI enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants