Initial code commit #2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| linters-settings: | ||
| depguard: | ||
| list-type: blacklist | ||
| packages: | ||
| # logging is allowed only by logutils.Log, logrus | ||
| # is allowed to use only in logutils package | ||
| - github.com/sirupsen/logrus | ||
| packages-with-error-message: | ||
| - github.com/sirupsen/logrus: "logging is allowed only by logutils.Log" | ||
| dupl: | ||
| threshold: 100 | ||
| exhaustive: | ||
| default-signifies-exhaustive: false | ||
| funlen: | ||
| lines: 100 | ||
| statements: 50 | ||
| gci: | ||
| local-prefixes: github.com/golangci/golangci-lint | ||
| goconst: | ||
| min-len: 2 | ||
| min-occurrences: 2 | ||
| gocritic: | ||
| enabled-tags: | ||
| - diagnostic | ||
| - experimental | ||
| - opinionated | ||
| - performance | ||
| - style | ||
| disabled-checks: | ||
| - dupImport # https://github.com/go-critic/go-critic/issues/845 | ||
| - ifElseChain | ||
| - octalLiteral | ||
| - whyNoLint | ||
| - wrapperFunc | ||
| gocyclo: | ||
| min-complexity: 15 | ||
| goimports: | ||
| local-prefixes: github.com/golangci/golangci-lint | ||
| golint: | ||
| min-confidence: 0 | ||
| gomnd: | ||
| settings: | ||
| mnd: | ||
| # don't include the "operation" and "assign" | ||
| checks: argument,case,condition,return | ||
| gosec: | ||
| settings: | ||
| exclude: -G204 | ||
| govet: | ||
| check-shadowing: false | ||
| settings: | ||
| printf: | ||
| funcs: | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf | ||
| lll: | ||
| line-length: 950 | ||
| maligned: | ||
| suggest-new: true | ||
| misspell: | ||
| locale: US | ||
| nolintlint: | ||
| allow-leading-space: true # don't require machine-readable nolint directives (i.e. with no leading space) | ||
| allow-unused: false # report any unused nolint directives | ||
| require-explanation: false # don't require an explanation for nolint directives | ||
| require-specific: false # don't require nolint directives to be specific about which linter is being skipped | ||
|
|
||
| linters: | ||
| # please, do not use `enable-all`: it's deprecated and will be removed soon. | ||
| # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint | ||
| # https://golangci-lint.run/usage/linters/ | ||
| disable-all: true | ||
| enable: | ||
| # TODO: consider continuously if more should be enabled. | ||
| # Can also be useful to run with more strict settings before commit locally, i.e. to test for TODOs (godox) | ||
| # - bodyclose | ||
| - deadcode | ||
| - dogsled | ||
| # - dupl | ||
| - errcheck | ||
| # - exhaustive | ||
| # - funlen | ||
| # - goconst | ||
| # - gocritic | ||
| # - gocyclo | ||
| - gofmt | ||
| - goimports | ||
| - golint | ||
| - gomodguard | ||
| - gosec | ||
| # - gomnd | ||
| # - goprintffuncname | ||
| - gosimple | ||
| - govet | ||
| - ineffassign | ||
| # - interfacer | ||
| - lll | ||
| - misspell | ||
| # - nakedret | ||
| # - nolintlint | ||
| # - rowserrcheck | ||
| # - scopelint | ||
| - staticcheck | ||
| - structcheck | ||
| - stylecheck | ||
| - typecheck | ||
| # - unconvert | ||
| # - unparam | ||
| - unused | ||
| - varcheck | ||
| - whitespace | ||
| - asciicheck | ||
| # - gochecknoglobals | ||
| # - gocognit | ||
| # - godot | ||
| # - godox | ||
| # - goerr113 | ||
| # - maligned | ||
| # - nestif | ||
| # - prealloc | ||
| # - testpackage | ||
| # - wsl | ||
|
|
||
| issues: | ||
| # Excluding configuration per-path, per-linter, per-text and per-source | ||
| exclude-rules: | ||
| - path: _test\.go | ||
| linters: | ||
| - gomnd | ||
|
|
||
| # https://github.com/go-critic/go-critic/issues/926 | ||
| - linters: | ||
| - gocritic | ||
| text: "unnecessaryDefer:" | ||
|
|
||
| run: | ||
| skip-dirs: | ||
| - test/testdata_etc | ||
| - internal/cache | ||
| - internal/renameio | ||
| - internal/robustio | ||
| timeout: 5m |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| check: | ||
|
There was a problem hiding this comment. Maybe we can add There was a problem hiding this comment. Good suggestion 👍 There was a problem hiding this comment. Yep, we can add |
||
| golangci-lint run | ||
|
|
||
| check-clean-cache: | ||
| golangci-lint cache clean | ||
|
|
||
| protoc-setup: | ||
| wget -P meshes https://raw.githubusercontent.com/layer5io/meshery/master/meshes/meshops.proto | ||
|
|
||
| proto: | ||
| protoc -I meshes/ meshes/meshops.proto --go_out=plugins=grpc:./meshes/ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this mean of all the PR would run the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that the CI runs on any branch one pushes to, especially also any branch in personal forks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember right, Github decreased the number of CI of the repo, can these make 0 effect to us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't thought about that (but heard about it too). As most branches exist in personal forks, I think it would not contribute to the Layer5 budget. Let's keep an eye on it. Would be interested to see whether there is a count somewhere that shows usage...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/pricing
https://docs.github.com/en/free-pro-team@latest/actions/reference/usage-limits-billing-and-administration#about-billing-for-github-actions
https://docs.github.com/en/free-pro-team@latest/actions/reference/usage-limits-billing-and-administration#usage-limits