-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add new and modify existing targets in Makefile related to code quality #5
Comments
@kumarabd why was this issue closed? As far as I can see, it has not been implemented. |
@mgfeller that was my mistake, was going to reopen it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think it could be useful to establish a standard / template (and mark it as such) that we just can copy to the various repositories, to implement this quickly, including the corresponding tool config and entries in the ci workflow. Or do we already have that? |
@mgfeller Sounds great to have a template! There is no template of |
@Aisuko which of the existing local checks in the layer5 repos would you recommend as starting point? |
@mgfeller Thank you, for my personal, I'd like to recommend https://github.com/layer5io/meshsync/blob/v0.1.2/Makefile , but we should replace the |
Current Behavior
gofmt
andgoimport
warnings fromgolangci-lint
, and to tidy modgolangci-lint
is calledcheck
(similar for clearing its cache)go mod verify
executed, and that could be useful tooDesired Behavior
golangci-run
called from targetcheck
, or renamecheck
togolangci-run
clean
, executinggo clean
andgolangci-lint cache clean
verify
executinggo mod verify
tidy
executinggo mod tidy
,gofmt -w .
,goimports -w .
Resources
Makefiles in other Layer5 (adapter) repositories.
The text was updated successfully, but these errors were encountered: