Repository navigation
test(flowchart): add the collate/hourglass alias pair to the alias suite - #7972
Conversation
aliasSet40 was declared but missing from the aliasSets array, so the collate/hourglass alias pair had no visual regression coverage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ftYK49bbNLySKsY1Pg1Rg
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe flowchart shape alias test now adds ChangesFlowchart alias coverage
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7972 +/- ##
===========================================
+ Coverage 77.45% 77.46% +0.01%
===========================================
Files 564 564
Lines 74840 74840
Branches 14600 14600
===========================================
+ Hits 57967 57978 +11
+ Misses 15876 15864 -12
- Partials 997 998 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Gentle nudge (no rush) - this is a one-line, test-only follow-up that adds the collate/hourglass alias pair to the flowchart alias suite (the Its |
|
Merged current No change to the test itself: still the one-line addition of the |
Description
aliasSet40(collate/hourglass) is declared incypress/integration/rendering/flowchart/flowchart-shape-alias.spec.tsbut was never added to thealiasSetsarray (it jumps fromaliasSet39toaliasSet41), so that alias pair has no visualregression coverage. This adds the missing entry.
Follow-up to the review note in
#7970 (comment) (the gap predates that PR).
Argos is expected to only ADD the new alias sheet.
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_017ftYK49bbNLySKsY1Pg1Rg
Summary
aliasSet40to the flowchart alias test suite.collate/hourglassalias pair.