Skip to content

test(flowchart): add the collate/hourglass alias pair to the alias suite - #7972

Merged
pbrolin47 merged 2 commits into
mermaid-js:developfrom
filipsajdak:test/flowchart-collate-alias
Jul 31, 2026
Merged

pbrolin47 merged 2 commits into
mermaid-js:developfrom
filipsajdak:test/flowchart-collate-alias

Conversation

@filipsajdak

@filipsajdak filipsajdak commented Jul 17, 2026 •

Copy link
Copy Markdown
Collaborator

Description

aliasSet40 (collate / hourglass) is declared in
cypress/integration/rendering/flowchart/flowchart-shape-alias.spec.ts but was never added to the
aliasSets array (it jumps from aliasSet39 to aliasSet41), so that alias pair has no visual
regression coverage. This adds the missing entry.

Follow-up to the review note in
#7970 (comment) (the gap predates that PR).

Argos is expected to only ADD the new alias sheet.

Checklist

🤖 Generated with Claude Code

https://claude.ai/code/session_017ftYK49bbNLySKsY1Pg1Rg

Summary

  • Added aliasSet40 to the flowchart alias test suite.
  • Restored visual regression coverage for the collate / hourglass alias pair.
  • Test-only change expected to add one Argos alias sheet.

aliasSet40 was declared but missing from the aliasSets array, so the
collate/hourglass alias pair had no visual regression coverage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017ftYK49bbNLySKsY1Pg1Rg
@netlify

netlify Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 2377cc8
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6a6b4baf37b01d0008f2bfb0
😎 Deploy Preview https://deploy-preview-7972--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2377cc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d6ddd5c4-aa75-417b-ac11-78f51f86c82c

📥 Commits

Reviewing files that changed from the base of the PR and between f0ffb41 and 602b510.

📒 Files selected for processing (1)
  • cypress/integration/rendering/flowchart/flowchart-shape-alias.spec.ts

📝 Walkthrough

Walkthrough

The flowchart shape alias test now adds aliasSet40 to the aggregated alias sets, so its rendering and snapshot cases execute with the existing parameterized test loop.

Changes

Flowchart alias coverage

Layer / File(s) Summary
Include aliasSet40 in rendering coverage
cypress/integration/rendering/flowchart/flowchart-shape-alias.spec.ts
The aliasSets array now includes aliasSet40, adding its aliases to rendering and snapshot coverage.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the flowchart alias suite change and the specific collate/hourglass alias pair.
Description check ✅ Passed The description explains the missing aliasSet40 coverage and includes a checklist, though it omits the issue link and design decisions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/@mermaid-js/examples@7972

mermaid

npm i https://pkg.pr.new/mermaid@7972

@mermaid-js/layout-elk

npm i https://pkg.pr.new/@mermaid-js/layout-elk@7972

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/@mermaid-js/layout-tidy-tree@7972

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/@mermaid-js/mermaid-zenuml@7972

@mermaid-js/parser

npm i https://pkg.pr.new/@mermaid-js/parser@7972

@mermaid-js/tiny

npm i https://pkg.pr.new/@mermaid-js/tiny@7972

commit: 2377cc8

@codecov

codecov Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.46%. Comparing base (4bc79dd) to head (2377cc8).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7972      +/-   ##
===========================================
+ Coverage    77.45%   77.46%   +0.01%     
===========================================
  Files          564      564              
  Lines        74840    74840              
  Branches     14600    14600              
===========================================
+ Hits         57967    57978      +11     
+ Misses       15876    15864      -12     
- Partials       997      998       +1     
Flag Coverage Δ
e2e 70.62% <ø> (+0.10%) ⬆️
unit 74.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci

argos-ci Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Approved by pbrolin47 20 changed Jul 30, 2026, 1:45 PM

@filipsajdak

Copy link
Copy Markdown
Collaborator Author

Gentle nudge (no rush) - this is a one-line, test-only follow-up that adds the collate/hourglass alias pair to the flowchart alias suite (the aliasSet40 gap @pbrolin47 spotted during the #7970 review). Green on the required checks.

Its argos build is stuck "queued" for the same reason as #7874: an upstream e2e.yml bug where a scope-reduced PR produces fewer screenshot buckets than the hard-coded --parallel-total, so Argos waits forever for shards that never upload (diagnosis + suggested one-line fix). @sidharthv96 happy to send that workflow fix as its own small PR if it'd help unblock the scoped-run Argos builds - just say the word.

@filipsajdak

Copy link
Copy Markdown
Collaborator Author

Merged current develop in to pick up @aloisklink's #7948 (landed 28 July), which should let the Argos build here finalize instead of sitting queued - the stall came from the scope-reduced e2e run declaring more Argos shards than it uploaded.

No change to the test itself: still the one-line addition of the collate/hourglass alias pair to aliasSets in flowchart-shape-alias.spec.ts, filling a gap @pbrolin47 spotted while reviewing #7970.

@pbrolin47
pbrolin47 added this pull request to the merge queue Jul 31, 2026
Merged via the queue into mermaid-js:develop with commit 19563d8 Jul 31, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Other Not an enhancement or a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants