Repository navigation
chore: Disable failing visual tests - #7728
Merged
Merged
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
Type: Other
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7728 +/- ##
=======================================
Coverage 3.29% 3.29%
=======================================
Files 561 560 -1
Lines 58576 58565 -11
Branches 873 873
=======================================
Hits 1928 1928
+ Misses 56648 56637 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
pbrolin47
marked this pull request as ready for review
May 11, 2026 08:00
ashishjain0512
approved these changes
May 11, 2026
ashishjain0512
approved these changes
May 11, 2026
This was referenced May 12, 2026
pull Bot
pushed a commit
to Liqiun/mermaid
that referenced
this pull request
May 12, 2026
The renderer seeded its mulberry32 PRNG from hashString(id) where the SVG element id varies per render, so each render produced a different wavy boundary and Argos visual tests failed on every run. Adds a `cynefin.seed` config field (default 0 → existing per-id hashing behavior; any non-zero value locks the waviness across renders). Extracts a `resolveSeed(configuredSeed, id)` helper alongside the existing PRNG primitives, hardened against non-finite inputs. The cypress helper now injects `cynefin.seed = 1` alongside the existing `handDrawnSeed = 1`, and the cynefin cypress spec (skipped in mermaid-js#7728 pending this fix) is re-enabled with one added seed-override test. Resolves mermaid-js#7727
pull Bot
pushed a commit
to weiyilai/mermaid
that referenced
this pull request
May 13, 2026
The cytoscape-fcose layout calls Math.random() internally in its constraint solver regardless of randomize:false, so the visual test 'should render a deterministic layout for a complex deeply-nested diagram' failed on every CI run (and was disabled in mermaid-js#7728 pending this fix). Adds an `architecture.seed` config field (default 1) that temporarily swaps Math.random for a mulberry32 seeded generator around the two layout.run() invocations and restores it in a finally block. The non-zero default makes every architecture diagram render with the same layout on every render; setting `architecture.seed: 0` opts out of the swap and restores the pre-fix non-deterministic behavior for callers who want layout variety. Re-enables the previously skipped cypress test, injects `architecture.seed = 1` from the test helper alongside handDrawnSeed=1, and adds a new test that exercises an explicit seed override. Resolves mermaid-js#7729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
The visual test 'should render a deterministic layout for a complex deeply-nested diagram' for Architecture diagrams is disabled since it fails in CI
The visual tests for Cynefin diagrams are disabled since they fail in CI.
During work with this PR, a problem was found that handling of subset screenshots was correct. In this PR a minor fix for that is added
Note: Separate issues are be raised to fix the failing tests. See https://github.com/mermaid-js/mermaid/issues/7727 and https://github.com/mermaid-js/mermaid/issues/7729
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.