Skip to content

7156:Support quoted string labels in architecture diagrams - #7310

Merged
ashishjain0512 merged 3 commits into
developfrom
fix/architecture-string-labels
Jan 23, 2026
Merged

ashishjain0512 merged 3 commits into
developfrom
fix/architecture-string-labels

Conversation

@darshanr0107

@darshanr0107 darshanr0107 commented Jan 12, 2026 •

Copy link
Copy Markdown
Contributor

📑 Summary

This PR fixes a parsing error in architecture-beta diagrams where labels wrapped in quotes
(e.g. ["Database"]) caused a syntax error.
Resolves #7156

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot

changeset-bot Bot commented Jan 12, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d106dd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jan 12, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit d106dd4
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/69677f27b73ff20008e4f0c6
😎 Deploy Preview https://deploy-preview-7310--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added Type: Bug / Error Something isn't working or is incorrect Sponsored by MermaidChart labels Jan 12, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jan 12, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7310

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7310

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7310

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7310

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7310

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7310

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7310

commit: d106dd4

@argos-ci

argos-ci Bot commented Jan 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jan 14, 2026, 12:08 PM

Comment thread packages/parser/src/language/architecture/valueConverter.ts Outdated
Comment thread packages/parser/tests/architecture.test.ts
…trophes in titles

on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
@codecov

codecov Bot commented Jan 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.58%. Comparing base (9745f32) to head (d106dd4).
⚠️ Report is 85 commits behind head on develop.

Files with missing lines Patch % Lines
...parser/src/language/architecture/valueConverter.ts 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7310      +/-   ##
==========================================
- Coverage     3.58%   3.58%   -0.01%     
==========================================
  Files          473     474       +1     
  Lines        47506   47525      +19     
  Branches       739     739              
==========================================
  Hits          1705    1705              
- Misses       45801   45820      +19     
Flag Coverage Δ
unit 3.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...parser/src/language/architecture/valueConverter.ts 4.16% <0.00%> (-2.09%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@darshanr0107
darshanr0107 requested a review from omkarht January 14, 2026 12:03

@omkarht omkarht left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me !!!

@ashishjain0512
ashishjain0512 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into develop with commit 09d0650 Jan 23, 2026
27 checks passed
@ashishjain0512
ashishjain0512 deleted the fix/architecture-string-labels branch January 23, 2026 15:09
This was referenced Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Architecture String Labels

3 participants