Skip to content

Fix edge labels for ER and requirement diagrams when config.flowchart.htmlLabels is false - #7296

Merged
aloisklink merged 1 commit into
developfrom
requirement-and-ER-diagram-edge-labels
Jan 6, 2026
Merged

aloisklink merged 1 commit into
developfrom
requirement-and-ER-diagram-edge-labels

Conversation

@darshanr0107

@darshanr0107 darshanr0107 commented Jan 6, 2026 •

Copy link
Copy Markdown
Contributor

📑 Summary

This PR fixes edge label rendering issues in ER and requirement diagrams when flowchart.htmlLabels is set to false.

Note: This PR should be merged before #6995

Before
before

After
After

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

…art: { htmlLabels: false }

on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
@changeset-bot

changeset-bot Bot commented Jan 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: aac86f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jan 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit aac86f7
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/695d1b7556d9740008f9db34
😎 Deploy Preview https://deploy-preview-7296--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@darshanr0107 darshanr0107 changed the title Fix requirement diagram edge labels for ER and requirement diagram when flowchart htmlLabels are falses when htmlLabels=false Fix edge labels for ER and requirement diagrams when flowchart htmlLabels are false Jan 6, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jan 6, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7296

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7296

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7296

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7296

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7296

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7296

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7296

commit: aac86f7

@codecov

codecov Bot commented Jan 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.57%. Comparing base (d5bc07d) to head (aac86f7).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/mermaid/src/diagrams/requirement/styles.js 0.00% 9 Missing ⚠️
packages/mermaid/src/diagrams/er/styles.ts 0.00% 3 Missing ⚠️
.../mermaid/src/diagrams/requirement/requirementDb.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7296      +/-   ##
==========================================
- Coverage     3.57%   3.57%   -0.01%     
==========================================
  Files          473     474       +1     
  Lines        47475   47498      +23     
  Branches       734     734              
==========================================
  Hits          1696    1696              
- Misses       45779   45802      +23     
Flag Coverage Δ
unit 3.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../mermaid/src/diagrams/requirement/requirementDb.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/er/styles.ts 0.00% <0.00%> (ø)
...ackages/mermaid/src/diagrams/requirement/styles.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci

argos-ci Bot commented Jan 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 58 changed, 4 added Jan 6, 2026, 2:37 PM

@aloisklink aloisklink left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darshanr0107, can you maybe add a before and after screenshot to the PR description? After that, I think it's good to merge.

@aloisklink aloisklink changed the title Fix edge labels for ER and requirement diagrams when flowchart htmlLabels are false Fix edge labels for ER and requirement diagrams when config.flowchart.htmlLabels is false Jan 6, 2026
@aloisklink aloisklink added the Type: Bug / Error Something isn't working or is incorrect label Jan 6, 2026
@aloisklink
aloisklink added this pull request to the merge queue Jan 6, 2026
Merged via the queue into develop with commit 66f0c6c Jan 6, 2026
27 checks passed
@aloisklink
aloisklink deleted the requirement-and-ER-diagram-edge-labels branch January 6, 2026 15:36
This was referenced Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sponsored by MermaidChart Type: Bug / Error Something isn't working or is incorrect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants