Skip to content

revert: restore original hexagon and roundedRect implementations - #7139

Merged
ashishjain0512 merged 8 commits into
developfrom
refactor/shape-rendering-simplification
Jan 22, 2026
Merged

ashishjain0512 merged 8 commits into
developfrom
refactor/shape-rendering-simplification

Conversation

@omkarht

@omkarht omkarht commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

📑 Summary

This PR reverts the hexagon and roundedRect shape implementations back to their original code.
These changes remove the dependencies on the simplified helper functions that were previously introduced.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot

changeset-bot Bot commented Nov 7, 2025 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 36dacb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Nov 7, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 36dacb7
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/696f8b210ef44200088378c2
😎 Deploy Preview https://deploy-preview-7139--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Nov 7, 2025 •

Copy link
Copy Markdown

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7139

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7139

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7139

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7139

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7139

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7139

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7139

commit: 36dacb7

@codecov

codecov Bot commented Nov 7, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.63158% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.59%. Comparing base (4261d3e) to head (36dacb7).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...endering-util/rendering-elements/shapes/hexagon.ts 0.00% 29 Missing ⚠️
...ring-util/rendering-elements/shapes/roundedRect.ts 11.11% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7139   +/-   ##
=======================================
  Coverage     3.59%   3.59%           
=======================================
  Files          474     475    +1     
  Lines        47471   47394   -77     
  Branches       740     740           
=======================================
+ Hits          1705    1706    +1     
+ Misses       45766   45688   -78     
Flag Coverage Δ
unit 3.59% <2.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ring-util/rendering-elements/shapes/roundedRect.ts 7.69% <11.11%> (+7.69%) ⬆️
...endering-util/rendering-elements/shapes/hexagon.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci

argos-ci Bot commented Nov 7, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 231 changed Jan 20, 2026, 2:14 PM

@omkarht
omkarht marked this pull request as ready for review November 7, 2025 11:25
@omkarht
omkarht requested a review from darshanr0107 December 18, 2025 09:44

@darshanr0107 darshanr0107 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashishjain0512
ashishjain0512 added this pull request to the merge queue Jan 22, 2026
Merged via the queue into develop with commit 78d8f64 Jan 22, 2026
26 checks passed
@ashishjain0512
ashishjain0512 deleted the refactor/shape-rendering-simplification branch January 22, 2026 13:06
This was referenced Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sponsored by MermaidChart Type: Other Not an enhancement or a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants