Skip to content

7000: Fix mindmap rendering issue when Level 2 nodes exceed 11 - #7099

Merged
sidharthv96 merged 5 commits into
developfrom
fix/mindmap-level-node-rendering
Nov 14, 2025
Merged

sidharthv96 merged 5 commits into
developfrom
fix/mindmap-level-node-rendering

Conversation

@darshanr0107

@darshanr0107 darshanr0107 commented Oct 22, 2025 •

Copy link
Copy Markdown
Contributor

📑 Summary

This PR fixes an issue where mindmap Level 2 nodes beyond the 11th rendered incorrectly.
Affected nodes appeared in black and were disconnected from the graph
Resolves #7000

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot

changeset-bot Bot commented Oct 22, 2025 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 03e8589

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Oct 22, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 03e8589
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6916c1c5e85188000803d7ff
😎 Deploy Preview https://deploy-preview-7099--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added Type: Bug / Error Something isn't working or is incorrect Sponsored by MermaidChart labels Oct 22, 2025
@pkg-pr-new

pkg-pr-new Bot commented Oct 22, 2025 •

Copy link
Copy Markdown

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7099

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7099

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7099

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7099

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7099

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7099

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7099

commit: 03e8589

@codecov

codecov Bot commented Oct 22, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.55%. Comparing base (fed8a52) to head (03e8589).
⚠️ Report is 97 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/mindmap/mindmapDb.ts 0.00% 2 Missing ⚠️
packages/mermaid/src/diagrams/mindmap/svgDraw.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7099      +/-   ##
==========================================
- Coverage     3.55%   3.55%   -0.01%     
==========================================
  Files          473     473              
  Lines        47480   47497      +17     
  Branches       730     731       +1     
==========================================
  Hits          1687    1687              
- Misses       45793   45810      +17     
Flag Coverage Δ
unit 3.55% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/mindmap/svgDraw.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/mindmap/mindmapDb.ts 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci

argos-ci Bot commented Oct 22, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 added Nov 14, 2025, 5:56 AM

on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
@darshanr0107 darshanr0107 changed the title Fix mindmap rendering issue when Level 2 nodes exceed 11 7000: Fix mindmap rendering issue when Level 2 nodes exceed 11 Oct 27, 2025
Comment thread packages/mermaid/src/diagrams/mindmap/mindmapDb.ts Outdated
Comment thread packages/mermaid/src/diagrams/mindmap/mindmapDb.ts Outdated
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
@sidharthv96
sidharthv96 added this pull request to the merge queue Nov 14, 2025
Merged via the queue into develop with commit ecf9ea1 Nov 14, 2025
26 checks passed
@sidharthv96
sidharthv96 deleted the fix/mindmap-level-node-rendering branch November 14, 2025 12:32
This was referenced Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sponsored by MermaidChart Type: Bug / Error Something isn't working or is incorrect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mindmap rendering broken when the number of level 2 nodes exceeds 11

2 participants