Repository navigation
mindmap breaking issue in ELK layout - #7019
Conversation
🦋 Changeset detectedLatest commit: 8b3057f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7019 +/- ##
==========================================
- Coverage 3.57% 3.55% -0.03%
==========================================
Files 474 474
Lines 47150 47465 +315
Branches 730 730
==========================================
Hits 1687 1687
- Misses 45463 45778 +315
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a mindmap rendering issue in ELK layout where Mermaid failed with a type error by restructuring how NodeWithVertex objects are created and handled in the rendering process.
- Replaces type assertion with explicit object construction for better type safety
- Removes redundant
nodeDbassignment that was causing conflicts - Adds improved error logging for debugging ELK layout issues
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/mermaid-layout-elk/src/render.ts | Fixes type handling and object creation for nodes, removes duplicate nodeDb assignment, adds error logging |
| cypress/platform/knsv2.html | Adds test cases for mindmap with ELK layout to verify the fix |
| .changeset/slow-lemons-know.md | Documents the bug fix in the changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
📑 Summary
This PR fixes a mindmap rendering issue in ELK layout where Mermaid failed with type error
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.