Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed box resizing in Journey Diagrams #6246

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

nour0205
Copy link

@nour0205 nour0205 commented Feb 1, 2025

📑 Summary

This PR fixes the issue where boxes in the Journey Diagram did not automatically adjust to accommodate large amounts of text. The boxes now dynamically resize based on the text content, ensuring the diagram displays correctly.

Resolves #6243

📏 Design Decisions

The implementation adjusts the height of the boxes dynamically by calculating the required space based on the length of the text and the number of lines it occupies. Additionally, the diagram's viewBox and height are updated to prevent cropping. These changes ensure proper rendering regardless of the amount of text in the boxes.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: 7c03c85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Feb 1, 2025
Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit e5ad6ba
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/679e89a03e868b0008951704
😎 Deploy Preview https://deploy-preview-6246--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 1, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6246
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6246
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6246
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6246

commit: e5ad6ba

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 4.47%. Comparing base (8dd0e7a) to head (e5ad6ba).

Files with missing lines Patch % Lines
...kages/mermaid/src/diagrams/user-journey/svgDraw.js 0.00% 35 Missing ⚠️
...rmaid/src/diagrams/user-journey/journeyRenderer.ts 0.00% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6246      +/-   ##
==========================================
- Coverage     4.47%   4.47%   -0.01%     
==========================================
  Files          385     384       -1     
  Lines        54191   54220      +29     
  Branches       598     623      +25     
==========================================
  Hits          2425    2425              
- Misses       51766   51795      +29     
Flag Coverage Δ
unit 4.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rmaid/src/diagrams/user-journey/journeyRenderer.ts 0.00% <0.00%> (ø)
...kages/mermaid/src/diagrams/user-journey/svgDraw.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@nour0205 nour0205 force-pushed the bug/6243_Fixed-box-resizing-in-Journey-Diagrams-to-handle-large-text-without-cropping branch from 96c7d31 to e5ad6ba Compare February 1, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxes do not automatically adjust with large amount of text in Journey Diagram
1 participant