Bring QA (0.6.9) changes to dev #6296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: check for env value before setting * Use empty instead of none
The local build script for Linux was failing due to a bundling error. This commit updates the `build:tauri:linux` script in `package.json` to be consistent with the CI build pipeline, which resolves the issue. The updated script now includes: - **`NO_STRIP=1`**: This environment variable prevents the `linuxdeploy` utility from stripping debugging symbols, which was a potential cause of the bundling failure. - **`--verbose`**: This flag provides more detailed output during the build, which can be useful for debugging similar issues in the future.
…d-model fix: compatibility imported model
fix: update copy offload_mmproj setting desc
…model fix: handle manual toggle vision for remote model
…itor fix: system monitor window permission
fix: update ui info
chore: update credit description
qnixsynapse
approved these changes
Aug 26, 2025
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to cad5b56 in 2 minutes and 24 seconds. Click for details.
- Reviewed
728lines of code in15files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/llamacpp-extension/settings.json:8
- Draft comment:
Changed default for llamacpp_env from 'none' to empty string. Ensure that the consuming code correctly handles an empty string (and doesn’t assume a non-empty default). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. web-app/src/services/models.ts:283
- Draft comment:
In pullModelWithMetadata, the regex for extracting the repo and filename is hard-coded. Consider moving the regex pattern to a constant or helper to ease maintenance and allow caching of metadata if the same repo is accessed repeatedly. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. web-app/src/services/models.ts:465
- Draft comment:
The function checkMmprojExistsAndUpdateOffloadMMprojSetting uses both provider update functions and a fallback via localStorage. Consider refactoring this logic into a single unified update mechanism to improve clarity and reduce code duplication. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. web-app/src/services/models.ts:595
- Draft comment:
In isModelSupported, if the engine’s method isn’t available the function falls back to returning 'YELLOW'. Document or reconsider this conservative fallback to ensure it aligns with expected behavior. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. web-app/src/services/models.ts:121
- Draft comment:
In fetchHuggingFaceRepo, consider adding caching for repository metadata when the same repo is requested multiple times, to reduce redundant network calls. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. web-app/src/containers/dialogs/EditModel.tsx:207
- Draft comment:
There's an extraneous '*/' appended to the closing tag on this line. It appears to be a stray comment closing and should be removed if not intended. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_1CKGO7K05VaVI4XR
You can customize 
dinhlongviolin1
added a commit
that referenced
this pull request
Aug 26, 2025
This reverts commit 02f7b88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important
Bring QA changes to dev, focusing on
llamacppextension updates, UI enhancements, and improved error handling.llamacpp_envdefault value insettings.jsonto an empty string.system-monitor-window.jsonfor hardware and deep-link access.onFileDownloadAndVerificationSuccessevent emission inindex.ts.index.ts.llamacpp_envis checked before parsing inindex.ts.build:tauri:linuxscript inpackage.jsonto include--verboseflag.openDelayandcloseDelaytoHoverCardinhover-card.tsx.ChatInput.tsxto handlemmprojsupport and file attachments with tooltips.DropdownModelProvider.tsxto conditionally renderModelSettingforllamacpp.ModelInfoHoverCard.tsxto display compatibility status and features.ModelSupportStatus.tsxto handle path resolution for model support checks.EditModel.tsx.settings.jsonto "Menlo Research team".Hubroute to improve model filtering and downloading logic.This description was created by
for cad5b56. You can customize this summary. It will automatically update as commits are pushed.