-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: update linux build script to be consistent with CI #6269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local build script for Linux was failing due to a bundling error. This commit updates the `build:tauri:linux` script in `package.json` to be consistent with the CI build pipeline, which resolves the issue. The updated script now includes: - **`NO_STRIP=1`**: This environment variable prevents the `linuxdeploy` utility from stripping debugging symbols, which was a potential cause of the bundling failure. - **`--verbose`**: This flag provides more detailed output during the build, which can be useful for debugging similar issues in the future.
Minh141120
approved these changes
Aug 22, 2025
dinhlongviolin1
approved these changes
Aug 22, 2025
Barecheck - Code coverage reportTotal: 36.1%Your code coverage diff: -0.01% ▾ ✅ All code changes are covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to c734982 in 20 minutes and 17 seconds. Click for details.
- Reviewed
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:25
- Draft comment:
The updated 'build:tauri:linux' script now sets NO_STRIP=1 and adds --verbose, aligning it with the CI pipeline. Ensure that shim-linuxdeploy.sh properly handles the --verbose flag. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. package.json:25
- Draft comment:
Verify that NO_STRIP=1 is only needed for shim-linuxdeploy.sh. If buildAppImage.sh (or other steps) requires similar flags, adjust accordingly. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_HRa6HI0b6I33hkST
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
dinhlongviolin1
added a commit
that referenced
this pull request
Aug 26, 2025
* fix: check for env value before setting (#6266) * fix: check for env value before setting * Use empty instead of none * fix: update linux build script to be consistent with CI (#6269) The local build script for Linux was failing due to a bundling error. This commit updates the `build:tauri:linux` script in `package.json` to be consistent with the CI build pipeline, which resolves the issue. The updated script now includes: - **`NO_STRIP=1`**: This environment variable prevents the `linuxdeploy` utility from stripping debugging symbols, which was a potential cause of the bundling failure. - **`--verbose`**: This flag provides more detailed output during the build, which can be useful for debugging similar issues in the future. * fix: compatibility imported model * fix: update copy mmproj setting desc * fix: toggle vision for remote model * chore: add tooltip visions * chore: show model setting only for local provider * fix/update-ui-info * chore: update filter hub while searching * fix: system monitor window permission * chore: update credit description --------- Co-authored-by: Akarshan Biswas <[email protected]> Co-authored-by: Faisal Amir <[email protected]> Co-authored-by: Minh141120 <[email protected]> Co-authored-by: Nguyen Ngoc Minh <[email protected]>
dinhlongviolin1
added a commit
that referenced
this pull request
Aug 28, 2025
* fix: check for env value before setting (#6266) * fix: check for env value before setting * Use empty instead of none * fix: update linux build script to be consistent with CI (#6269) The local build script for Linux was failing due to a bundling error. This commit updates the `build:tauri:linux` script in `package.json` to be consistent with the CI build pipeline, which resolves the issue. The updated script now includes: - **`NO_STRIP=1`**: This environment variable prevents the `linuxdeploy` utility from stripping debugging symbols, which was a potential cause of the bundling failure. - **`--verbose`**: This flag provides more detailed output during the build, which can be useful for debugging similar issues in the future. * fix: compatibility imported model * fix: update copy mmproj setting desc * fix: toggle vision for remote model * chore: add tooltip visions * chore: show model setting only for local provider * fix/update-ui-info * chore: update filter hub while searching * fix: system monitor window permission * chore: update credit description * chore: bundle license to app * chore: bundle license to resource mac * chore: bundle license to linux dist * chore: relocate LICENSE to resources folder * fix: handle paste image on linux * fix: handle copy image from browser in linux * feat: add regression checklist * fix: mcp cleanup dropodown tool availabel and sort list * fix: sort list when add server * fix: mcp sort list * fix: handle conditional UI regenerate resp * fix: code generation more than 300 line * fix: handle checking compatible gated model * chore: update test * chore: remove log * chore: fix status * chore: fix status model id * make validation message infinite (#6318) --------- Co-authored-by: Akarshan Biswas <[email protected]> Co-authored-by: Faisal Amir <[email protected]> Co-authored-by: Minh141120 <[email protected]> Co-authored-by: Nguyen Ngoc Minh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
The local build script for Linux was failing due to a bundling error. This commit updates the
build:tauri:linux
script inpackage.json
to be consistent with the CI build pipeline, which resolves the issue.The updated script now includes:
NO_STRIP=1
: This environment variable prevents thelinuxdeploy
utility from stripping debugging symbols, which was a potential cause of the bundling failure.--verbose
: This flag provides more detailed output during the build, which can be useful for debugging similar issues in the future.Fixes Issues
Self Checklist
Important
Update
build:tauri:linux
script inpackage.json
to fix bundling error by aligning with CI pipeline.build:tauri:linux
inpackage.json
to includeNO_STRIP=1
and--verbose
for consistency with CI.This description was created by
for c734982. You can customize this summary. It will automatically update as commits are pushed.