Skip to content

chore: Use --locked flag instead of --frozen of uv sync in Nox sessions#3035

Merged
edgarrmondragon merged 2 commits intomainfrom
chore/use-uv-sync-locked
May 13, 2025
Merged

chore: Use --locked flag instead of --frozen of uv sync in Nox sessions#3035
edgarrmondragon merged 2 commits intomainfrom
chore/use-uv-sync-locked

Conversation

@edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 13, 2025

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 13, 2025

Reviewer's Guide

Replaced the --frozen flag with --locked for all UV sync invocations in Nox sessions, ensuring consistency with the updated UV tool requirements.

Sequence Diagram: Update to uv sync Command Flag in Nox Sessions

sequenceDiagram
    participant NoxSession as "Nox Session (e.g., mypy, tests)"
    participant UVCLI as "`uv sync` Command Line Interface"

    NoxSession->>UVCLI: Call with `uv sync --frozen ...` (Previous behavior)
    NoxSession->>UVCLI: Call with `uv sync --locked ...` (New behavior introduced by PR)
Loading

File-Level Changes

Change Details Files
Swapped --frozen for --locked in UV sync calls across Nox sessions
  • mypy session install command
  • tests session install command
  • coverage session install command
  • benches session install command
  • dependencies session install command
  • update_snapshots session install command
  • doctest session install command
  • docs session install command
  • docs_serve session install command
noxfile.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @edgarrmondragon - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codspeed-hq
Copy link

codspeed-hq bot commented May 13, 2025

CodSpeed Performance Report

Merging #3035 will not alter performance

Comparing chore/use-uv-sync-locked (7f5e5e3) with main (0b62441)

Summary

✅ 8 untouched benchmarks

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner May 13, 2025 18:09
@edgarrmondragon edgarrmondragon merged commit 3a57f93 into main May 13, 2025
34 checks passed
@edgarrmondragon edgarrmondragon deleted the chore/use-uv-sync-locked branch May 13, 2025 18:22
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.64%. Comparing base (0b62441) to head (7f5e5e3).
⚠️ Report is 196 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3035   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files          62       62           
  Lines        5314     5314           
  Branches      685      685           
=======================================
  Hits         4870     4870           
  Misses        312      312           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant