melange-re · anmonteiro · Feb 17, 2024 · Feb 17, 2024 · Feb 17, 2024 · Feb 17, 2024
diff --git a/Changes.md b/Changes.md
@@ -17,6 +17,10 @@ Unreleased
 - runtime: add bindings to `Js.Set`
   ([#1047](https://github.com/melange-re/melange/pull/1047))
 - runtime: add minimal bindings for JS iterators ([#1060](https://github.com/melange-re/melange/pull/1060))
+- core: in compiled JS, emit `const` for variables that Melange knows aren't
+  going to be reassigned
+  ([#1019](https://github.com/melange-re/melange/pull/1019),
+  [#1059](https://github.com/melange-re/melange/pull/1059)).
 
 3.0.0 2024-01-28
 ---------------

diff --git a/jscomp/core/js_dump.ml b/jscomp/core/js_dump.ml
@@ -226,7 +226,7 @@ let pp_var_assign cxt id =
   acxt
 
 let pp_const_assign cxt id =
-  string cxt "const";
+  string cxt L.const;
   space cxt;
   let acxt = ident cxt id in
   space cxt;

diff --git a/jscomp/core/js_dump_import_export.ml b/jscomp/core/js_dump_import_export.ml
@@ -112,7 +112,7 @@ let requires require_lit cxt f (modules : (Ident.t * string * bool) list) =
   in
   P.at_least_two_lines f;
   List.rev_iter reversed_list (fun (s, file, default) ->
-      P.string f L.let_;
+      P.string f L.const;
       P.space f;
       P.string f s;
       P.space f;

diff --git a/jscomp/core/js_dump_lit.ml b/jscomp/core/js_dump_lit.ml
@@ -24,6 +24,7 @@
 
 let function_ = "function"
 let let_ = "let"
+let const = "const"
 let return = "return"
 let require = "require"
 let import = "import"

diff --git a/jscomp/test/dist/jscomp/test/406_primitive_test.js b/jscomp/test/dist/jscomp/test/406_primitive_test.js
diff --git a/jscomp/test/dist/jscomp/test/a_filename_test.js b/jscomp/test/dist/jscomp/test/a_filename_test.js
diff --git a/jscomp/test/dist/jscomp/test/a_list_test.js b/jscomp/test/dist/jscomp/test/a_list_test.js
diff --git a/jscomp/test/dist/jscomp/test/a_recursive_type.js b/jscomp/test/dist/jscomp/test/a_recursive_type.js
diff --git a/jscomp/test/dist/jscomp/test/a_string_test.js b/jscomp/test/dist/jscomp/test/a_string_test.js
diff --git a/jscomp/test/dist/jscomp/test/acyc/a1_a2.js b/jscomp/test/dist/jscomp/test/acyc/a1_a2.js
diff --git a/jscomp/test/dist/jscomp/test/acyc/a2_a3.js b/jscomp/test/dist/jscomp/test/acyc/a2_a3.js
diff --git a/jscomp/test/dist/jscomp/test/acyc/a3_a4.js b/jscomp/test/dist/jscomp/test/acyc/a3_a4.js
diff --git a/jscomp/test/dist/jscomp/test/acyc/a4_a5.js b/jscomp/test/dist/jscomp/test/acyc/a4_a5.js
diff --git a/jscomp/test/dist/jscomp/test/adt_optimize_test.js b/jscomp/test/dist/jscomp/test/adt_optimize_test.js
diff --git a/jscomp/test/dist/jscomp/test/and_or_tailcall_test.js b/jscomp/test/dist/jscomp/test/and_or_tailcall_test.js
diff --git a/jscomp/test/dist/jscomp/test/app_root_finder.js b/jscomp/test/dist/jscomp/test/app_root_finder.js
diff --git a/jscomp/test/dist/jscomp/test/argv_test.js b/jscomp/test/dist/jscomp/test/argv_test.js
diff --git a/jscomp/test/dist/jscomp/test/ari_regress_test.js b/jscomp/test/dist/jscomp/test/ari_regress_test.js
diff --git a/jscomp/test/dist/jscomp/test/arith_lexer.js b/jscomp/test/dist/jscomp/test/arith_lexer.js
diff --git a/jscomp/test/dist/jscomp/test/arith_parser.js b/jscomp/test/dist/jscomp/test/arith_parser.js
diff --git a/jscomp/test/dist/jscomp/test/arith_syntax.js b/jscomp/test/dist/jscomp/test/arith_syntax.js
diff --git a/jscomp/test/dist/jscomp/test/arity_deopt.js b/jscomp/test/dist/jscomp/test/arity_deopt.js
diff --git a/jscomp/test/dist/jscomp/test/arity_infer.js b/jscomp/test/dist/jscomp/test/arity_infer.js
diff --git a/jscomp/test/dist/jscomp/test/array_data_util.js b/jscomp/test/dist/jscomp/test/array_data_util.js
diff --git a/jscomp/test/dist/jscomp/test/array_safe_get.js b/jscomp/test/dist/jscomp/test/array_safe_get.js
diff --git a/jscomp/test/dist/jscomp/test/array_subtle_test.js b/jscomp/test/dist/jscomp/test/array_subtle_test.js
diff --git a/jscomp/test/dist/jscomp/test/array_test.js b/jscomp/test/dist/jscomp/test/array_test.js
diff --git a/jscomp/test/dist/jscomp/test/ast_abstract_test.js b/jscomp/test/dist/jscomp/test/ast_abstract_test.js
diff --git a/jscomp/test/dist/jscomp/test/ast_js_mapper_poly_test.js b/jscomp/test/dist/jscomp/test/ast_js_mapper_poly_test.js
diff --git a/jscomp/test/dist/jscomp/test/ast_js_mapper_test.js b/jscomp/test/dist/jscomp/test/ast_js_mapper_test.js
diff --git a/jscomp/test/dist/jscomp/test/ast_mapper_defensive_test.js b/jscomp/test/dist/jscomp/test/ast_mapper_defensive_test.js
diff --git a/jscomp/test/dist/jscomp/test/basic_module_test.js b/jscomp/test/dist/jscomp/test/basic_module_test.js
diff --git a/jscomp/test/dist/jscomp/test/bb.js b/jscomp/test/dist/jscomp/test/bb.js
diff --git a/jscomp/test/dist/jscomp/test/bdd.js b/jscomp/test/dist/jscomp/test/bdd.js
diff --git a/jscomp/test/dist/jscomp/test/belt_internal_test.js b/jscomp/test/dist/jscomp/test/belt_internal_test.js