feat: emit const instead of let for immutable assignment#1059
Merged
anmonteiro merged 4 commits intomainfrom Feb 13, 2024
Merged
feat: emit const instead of let for immutable assignment#1059anmonteiro merged 4 commits intomainfrom
anmonteiro merged 4 commits intomainfrom
Conversation
Member
Author
|
Going to go ahead and merge this to test in some other projects. It's easy to revert a single commit anyway. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1019, we're taking advantage of the fact that
letis lexically scoped, much alike OCaml'slet. It allows us to remove some loop-captured variable closures in #1020 and preserve the same guarantees syntactically.This change goes even further, by emitting
constin the generated JS for values that we know to be immutable assignment.