Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Conversation

@irevoire
Copy link
Contributor

Summary

Specify the auto-deletion of tasks that was introduced in meilisearch v1.2

Associated issue: meilisearch/meilisearch#3622
Implemented in: meilisearch/meilisearch#3693

@irevoire irevoire added the Implemented Feature specification has been implemented. label May 10, 2023
@irevoire irevoire requested a review from macraig May 10, 2023 12:56
@irevoire irevoire added the Ready For Review Feature specification must be reviewed. label May 10, 2023
@gmourier gmourier mentioned this pull request May 15, 2023
1 task
@gmourier gmourier self-requested a review May 15, 2023 06:56
Copy link
Member

@gmourier gmourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @irevoire! Should we also mention the behavior of blocking the write to the task queue when Meilisearch can't delete the task and has reached it's maximum size for the task db?

@irevoire
Copy link
Contributor Author

Huum, I think I would say no since it’s completely hidden from the end user 🤔
What do you think? Would you like to get it specified?

irevoire and others added 2 commits May 15, 2023 16:10
Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
Copy link
Member

@gmourier gmourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @irevoire

@gmourier gmourier removed the Ready For Review Feature specification must be reviewed. label May 24, 2023
@macraig macraig merged commit b3a7f4e into release-v1.2.0 Jun 5, 2023
@macraig macraig deleted the auto-deletion-of-tasks branch June 5, 2023 15:44
macraig pushed a commit that referenced this pull request Jun 5, 2023
* Bump OpenAPI version

* CSV Content-Type — Add support for the boolean type in CSV (#228)

* add support for the boolean type in csv

* fix a typo

* Update text/0028-indexing-csv.md

---------

Co-authored-by: Guillaume Mourier <[email protected]>

* Filter operators - `IS NULL` and `IS EMPTY` filter operators (#232)

* Introduce the spec of the IS EMPTY filter

* Introduce the spec of the IS NULL filter

* Fix suggestions

* Uppercase the IN operator

Co-authored-by: Guillaume Mourier <[email protected]>

* Fix a title number issue

Co-authored-by: Guillaume Mourier <[email protected]>

---------

Co-authored-by: Guillaume Mourier <[email protected]>

* Search Algorithms Refactor: Relevancy Changes (#233)

* Remove old exactness-criterion specification

* Remove old asc-desc-criterion specification

* Get and delete documents by filter (#236)

* specify the new fetch documents route

* update open-api

* try to be nice with bumpsh

* specify the new analytics of the get/fetch documents route

* group the analytics behind already used groups

* fix a placeholder text

* group the get and fetch route under a common section

* rename the section to contain the name of both routes

* clarify how to send the parameter to both routes

* fix the type of the parameters

* add the new fetch route to the api keys actions

* capitalize json

Co-authored-by: cvermand <[email protected]>

* update open-api

* Specify the new route to delete documents by filter

* add the new analytics event

* improve a comment

* add the post - delete route to the api key actions

* Fix the json payload

Co-authored-by: cvermand <[email protected]>

* Apply suggestions from code review

Co-authored-by: Guillaume Mourier <[email protected]>

* Update the details

Co-authored-by: Guillaume Mourier <[email protected]>

* delete the invalid_document_delete_filter error code and introduce the missing_document_filter

* fix the open-api thingy

---------

Co-authored-by: cvermand <[email protected]>
Co-authored-by: Guillaume Mourier <[email protected]>

* Auto deletion of tasks (#238)

* auto deletion of tasks

* Update text/0060-tasks-api.md

Co-authored-by: gui machiavelli <[email protected]>

* Update text/0060-tasks-api.md

Co-authored-by: gui machiavelli <[email protected]>

---------

Co-authored-by: gui machiavelli <[email protected]>

* Experimental reduce indexing memory usage (#239)

* Add the experimental-reduce-indexing-memory-usage option in the telemetry policies

* Add the experimental-reduce-indexing-memory-usage option in the instance options

* Update 0055-sort.md (#240)

related to meilisearch/meilisearch#3749

* Update `payload_too_large` error `message` (#241)

* Update 0061-error-format-and-definitions.md

Update error message in the specification

* Update open-api.yaml

---------

Co-authored-by: Tamo <[email protected]>
Co-authored-by: Clément Renault <[email protected]>
Co-authored-by: cvermand <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Many the fish <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Implemented Feature specification has been implemented. Q2:2023 v1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants