Fix back: sort error message #3749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
gmourier
approved these changes
May 15, 2023
irevoire
approved these changes
May 15, 2023
There was a problem hiding this comment.
However, this added double-quotes around sort in the message. I don't think another message contains double-quotes, so I have added a separate commit replacing the double-quotes with back-ticks, which seems more consistent with the other error messages, this last change can be reverted easily.
💯
ManyTheFish
added a commit
to meilisearch/specifications
that referenced
this pull request
May 16, 2023
Merged
meili-bors bot
added a commit
that referenced
this pull request
May 16, 2023
3755: Re-add final dot r=curquiza a=ManyTheFish I removed the final dot of the error message in my last PR, this one re-adds it. related to #3749 > Oups 😬 Co-authored-by: ManyTheFish <[email protected]>
macraig
pushed a commit
to meilisearch/specifications
that referenced
this pull request
Jun 5, 2023
macraig
pushed a commit
to meilisearch/specifications
that referenced
this pull request
Jun 5, 2023
* Bump OpenAPI version * CSV Content-Type — Add support for the boolean type in CSV (#228) * add support for the boolean type in csv * fix a typo * Update text/0028-indexing-csv.md --------- Co-authored-by: Guillaume Mourier <[email protected]> * Filter operators - `IS NULL` and `IS EMPTY` filter operators (#232) * Introduce the spec of the IS EMPTY filter * Introduce the spec of the IS NULL filter * Fix suggestions * Uppercase the IN operator Co-authored-by: Guillaume Mourier <[email protected]> * Fix a title number issue Co-authored-by: Guillaume Mourier <[email protected]> --------- Co-authored-by: Guillaume Mourier <[email protected]> * Search Algorithms Refactor: Relevancy Changes (#233) * Remove old exactness-criterion specification * Remove old asc-desc-criterion specification * Get and delete documents by filter (#236) * specify the new fetch documents route * update open-api * try to be nice with bumpsh * specify the new analytics of the get/fetch documents route * group the analytics behind already used groups * fix a placeholder text * group the get and fetch route under a common section * rename the section to contain the name of both routes * clarify how to send the parameter to both routes * fix the type of the parameters * add the new fetch route to the api keys actions * capitalize json Co-authored-by: cvermand <[email protected]> * update open-api * Specify the new route to delete documents by filter * add the new analytics event * improve a comment * add the post - delete route to the api key actions * Fix the json payload Co-authored-by: cvermand <[email protected]> * Apply suggestions from code review Co-authored-by: Guillaume Mourier <[email protected]> * Update the details Co-authored-by: Guillaume Mourier <[email protected]> * delete the invalid_document_delete_filter error code and introduce the missing_document_filter * fix the open-api thingy --------- Co-authored-by: cvermand <[email protected]> Co-authored-by: Guillaume Mourier <[email protected]> * Auto deletion of tasks (#238) * auto deletion of tasks * Update text/0060-tasks-api.md Co-authored-by: gui machiavelli <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: gui machiavelli <[email protected]> --------- Co-authored-by: gui machiavelli <[email protected]> * Experimental reduce indexing memory usage (#239) * Add the experimental-reduce-indexing-memory-usage option in the telemetry policies * Add the experimental-reduce-indexing-memory-usage option in the instance options * Update 0055-sort.md (#240) related to meilisearch/meilisearch#3749 * Update `payload_too_large` error `message` (#241) * Update 0061-error-format-and-definitions.md Update error message in the specification * Update open-api.yaml --------- Co-authored-by: Tamo <[email protected]> Co-authored-by: Clément Renault <[email protected]> Co-authored-by: cvermand <[email protected]> Co-authored-by: gui machiavelli <[email protected]> Co-authored-by: Many the fish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the error message modified in meilisearch/milli#375.
However, this added double-quotes around
sortin the message. I don't think another message contains double-quotes, so I have added a separate commit replacing the double-quotes with back-ticks, which seems more consistent with the other error messages, this last change can be reverted easily.Detailed changes
v1.2-rc0
Reintroduce fix (previous and expected behavior)
Replace double-quotes with back-ticks (my suggestion)
Related
Fixes #3722
Reviewers