Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keys api #252
Update keys api #252
Changes from 11 commits
b11cc41
e5cc747
16ebe3a
3245b68
6cff92e
d037c4b
d87d335
5bc9ddd
a960e23
6a113a9
4a98a0f
b3d7793
eaa54e3
8713d8b
a1f40fd
8750dbe
1c54692
344ab1f
2881a0a
482a750
e3703f6
ca1e35e
026ab54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this function for me (or send me some references about it), I didn't get what it will result, or how it is done (lack of swift expertise 😓)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, the JSON encoder of Swift considers that if one of your field is
nil
it means it can be removed from the JSON object.The problem in the key route is that
expiresAt
is mandatory.To workaround it I had to redefine exactly all the fields I want to be present after the encoding.