Update keys api #252
Merged
Update keys api #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
force-pushed
the
update_keys_api
branch
from
5f50a3a to
6cff92e
Compare
bidoubiwa
added
the
breaking-change
…search-swift into update_keys_api
bidoubiwa
commented
Feb 8, 2022
brunoocasali
reviewed
Feb 9, 2022
There was a problem hiding this comment.
Hey, @bidoubiwa I left some comments, let me know what do you think about them!
Awesome work! 🎉 🌮
bidoubiwa
force-pushed
the
update_keys_api
branch
from
345f199 to
b3d7793
Compare
…search-swift into update_keys_api
…swift into update_keys_api
Base automatically changed from
update_api_to_task_api
to
bump-meilisearch-v0.25.0
February 10, 2022 14:59
brunoocasali
approved these changes
Feb 10, 2022
bidoubiwa
force-pushed
the
update_keys_api
branch
from
6a4dcea to
026ab54
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys API changes!
Breaking
client.getkeysnow returns aResults<Key>object see specificationNew
client.getKeyreturns aKeyobject of a specific keyclient.createKeyreturns aKeyobject created with aKeyParamsobjectclient.updateKeyreturns aKeyobject with the updated keyclient.deleteKeyreturns void as the chosen key has been deleted